Skip to content

Update example to use Mbed OS 5.11.2 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2019

Conversation

dgreen-arm
Copy link
Contributor

@dgreen-arm dgreen-arm commented Jan 22, 2019

After updating to Mbed OS 5.11.2, Mbed OS prefers to use SD for storage over FLASHIAP if both are present. As the example should work on a K64F even without an SD, the SD component is removed to force Mbed OS to use FLASHIAP.

dgreen-arm and others added 2 commits January 22, 2019 13:54
Mbed OS prefers to use SD for storage over FLASHIAP if both are
present. As the example should work on a K64F even without an SD,
the SD component is removed to force Mbed OS to use FLASHIAP.
@dgreen-arm dgreen-arm changed the title Remove SD from K64F component list Update example to use Mbed OS 5.11.2 Jan 22, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 23, 2019

@ARMmbed/mbed-os-storage Which PR did cause this ? I am checking 5.11.2 PRs , haven't found it so far.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 23, 2019

@davidsaada helped me to find it: ARMmbed/mbed-os#8934 , this one caused this. @yossi2le You mentioned in the PR it was mistake, was this use case also considered?

@dannybenor
Copy link

@0xc0170 This is not new to 5.11.2, it is like this from the addition of FLASHAIP ARMmbed/mbed-os#8317

@davidsaada
Copy link

@dannybenor I think that the problem here is that KVStore init (called from somewhere inside PSA) fails if we don't have an SD card present. But @dgreen-arm should probably answer it better.

@dgreen-arm
Copy link
Contributor Author

I believe that's whats happening, the example was failing with KV Config: Fail to get external BlockDevice.

It looks like the example wasn't tested properly for the 5.11.1 release, as it worked with 5.11.0-rc4 but not 5.11.1.

@dannybenor
Copy link

dannybenor commented Jan 23, 2019

The example can work if you have an SD card in your K64F board. This is the right setup and the right mbed OS default because all tests of PDMC are done with SD cards and FATfs. I see no problem if a crypto example wants to work without SD card.

@Patater Patater merged commit c278b6e into ARMmbed:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants