Skip to content

Setting K64F to use KVStore FileSystem configuration #8934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

yossi2le
Copy link
Contributor

@yossi2le yossi2le commented Dec 2, 2018

Description

This PR change the default KVStore configuration of K64F to FILESYSTEM means, that KVStore will work over filesystem using the FileSystemStore implementation and SecureStore implementation.
Previously PR has changed it to TDB_INTERNAL, which was a mistake.

Pull request type

[ x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team December 3, 2018 11:08
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2018

Travis failure will be fixed on master soon (we will request rebase once done). See #8945

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2018

Travis failure will be fixed on master soon (we will request rebase once done). See #8945

The fix is on master, if you rebase, it should allow travis to run

@yossi2le yossi2le force-pushed the yossi_kvstore_k64F_FileSystem branch from 8f9a5b3 to d21bfbf Compare December 3, 2018 14:09
@cmonr
Copy link
Contributor

cmonr commented Dec 3, 2018

@yossi2le What's the difference between having storage_type set to TDB_INTERNAL vs FILESYSTEM?

@dannybenor
Copy link

@cmonr You can see the answer here https://github.com/ARMmbed/mbed-os-5-docs/blob/development/docs/reference/configuration/Storage.md#kvstore-configuration

@cmonr
Copy link
Contributor

cmonr commented Dec 4, 2018

CI started

@cmonr
Copy link
Contributor

cmonr commented Dec 4, 2018

@yossi2le @dannybenor PR looks fine to me, just wondering why the K64F would need a different config than the K66F. Is that because of the differenced between each eval board, and not just the chip family?

@dannybenor
Copy link

@cmonr It is more an issue of testing. K66F was selected by Pelion Client team to be the platform to test internal memory, while K64F is currently used with SD cards, and it is more suitable to test file system configuration.

@mbed-ci
Copy link

mbed-ci commented Dec 4, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 4, 2018

Test restarted, error not related to the change.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 4, 2018

Test restarted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants