Mbed Crypto examples on Mbed OS #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 19, 2018 11:15
First draft of README.md
Patater
suggested changes
Nov 19, 2018
added 5 commits
November 19, 2018 14:56
Example file main.cpp updated to use '\n' instead of '\r\n'.
itayzafrir
force-pushed
the
mbed-crypto-examples
branch
from
d7cdb07 to
093184e
Compare
Patater
approved these changes
Nov 19, 2018
|
|
||
| ## Deploy | ||
| The following are the steps required for deployment: | ||
| * Clone this repository: `git clone [email protected]:ARMmbed/mbed-os-example-mbed-crypto.git` |
There was a problem hiding this comment.
Does mbed import work with our example repo? I think it would clone and deploy all in one go. No need to worry about users having git keys set up or anything.
There was a problem hiding this comment.
I think it would work, but I cannot validate this before the branch is merged because there's no way of specifying a branch with mbed import.
There was a problem hiding this comment.
i have tried mbed import git clone [email protected]:ARMmbed/mbed-os-example-mbed-crypto
It works
There was a problem hiding this comment.
Yes I also validated that it works, the readme will be updated via #3
Patater
changed the title
NirSonnenschein
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mbed-Crypto examples running on mbed-os.
Note: the mbed-os.lib file is pointing to a branch on @mohammad1603 fork. This will need to be updated once a release is available.