Skip to content

Minor change on docs #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2018
Merged

Minor change on docs #3

merged 3 commits into from
Dec 4, 2018

Conversation

MarceloSalazar
Copy link

Just a few tweaks to have consistency with other Mbed OS examples

@Patater

Just a few tweaks to have consistency with other Mbed OS examples
README.md Outdated
The following are the steps required for deployment:
* Clone this repository: `git clone [email protected]:ARMmbed/mbed-os-example-mbed-crypto.git`
## Import
The following are the steps required for install the application:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend changing "for" to "to".

- the steps required for install the application
+ the steps required to install the application

@Patater Patater requested a review from itayzafrir November 30, 2018 17:23
Copy link
Contributor

@itayzafrir itayzafrir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the comment @Patater left, please fix the redundancy between the Program your board and Run sections.

@MarceloSalazar
Copy link
Author

Fixed. Hopefully is now ok.

@MarceloSalazar
Copy link
Author

Let's also update the mbed-os-5.11.0-oob branch

Copy link
Contributor

@itayzafrir itayzafrir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last tweak and then we're good.

Co-Authored-By: MarceloSalazar <[email protected]>
@Patater Patater merged commit b5a4e60 into master Dec 4, 2018
@Patater Patater deleted the minor-doc-tweak branch December 4, 2018 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants