Make our own multicast group and join it. #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not rely on any default multicast groups to be enabled. Don't spam nodes which have not joined our group. Fixes #130
1 task
kjbracey
approved these changes
Oct 4, 2017
|
|
||
| ns_ipv6_mreq_t mreq; | ||
| memcpy(mreq.ipv6mr_multiaddr, multi_cast_addr, 16); | ||
| mreq.ipv6mr_interface = 0; |
There was a problem hiding this comment.
Zero means "default". Best we can do as we don't have visibility of Nanostack interface IDs.
There is a PR going through to add a generic NSAPI for this - ARMmbed/mbed-os#4820. That is intending to use interface address instead.
|
Verified! |
kseverinkangas-zg
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not rely on any default multicast groups to be enabled.
Don't spam nodes which have not joined our group.
Fixes #130
This needs to be manually tested for both Thread and 6LoWPAN.