Skip to content

Enable MPL by default for 6LoWPAN-ND. #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Conversation

SeppoTakalo
Copy link
Contributor

@SeppoTakalo SeppoTakalo commented Oct 4, 2017

In Thread network, MPL is already enabled so this causes
both to behave similarly.

This is part of fixes for ARMmbed/mbed-os-example-mesh-minimal#130

Status

In test

Migrations

NO

Related PRs

List related PRs against other branches:

ARMmbed/mbed-os-example-mesh-minimal#137

Todos

  • Tests

In Thread network, MPL is already enabled so this causes
both to behave similarly.
@kseverinkangas-zg
Copy link

Verified!

@theotherjimmy
Copy link
Contributor

@SeppoTakalo You mention that tests were added? Where did you add tests? If this is a fix, I would like to see a test so that we don't break it again.

@SeppoTakalo
Copy link
Contributor Author

No, I did not add tests.
This was tested manually because it requires RF sniffer for verifying.

@studavekar
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2017

Build : SUCCESS

Build number : 91
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5252/

Triggering tests

/test mbed-os

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 11, 2017

/morph test-nightly

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1564

Build failed!

@SeppoTakalo
Copy link
Contributor Author

/home/jenkins/mbed_jenkins_iar_01_b10/workspace/bm_wrap/1650/mbed-os/drivers/BusIn.cpp
02:42:06         [DEBUG] Return: 2
02:42:06         [DEBUG] Output: Fatal error[LMS001]: License check failed. Use the IAR License Manager to
02:42:06         [DEBUG] Output:           resolve the problem. 
02:42:06         [DEBUG] Output: Failed to obtain feature: "ARM.EW.COMPILER_STD"
02:42:06         [DEBUG] Output:           version: "1.11".
02:42:06         [DEBUG] Output: Feature cannot run anymore because the license
02:42:06         [DEBUG] Output:           expiration date is reached. Status code 0xc800100d.
02:42:06         [DEBUG] Output:           [LicenseCheck:2.15.2.J2938, RMS:8.5.1.2009, Feature:ARM.EW.COMPILER,
02:42:06         [DEBUG] Output:           Version:1.10]
02:42:06         [DEBUG] Output: Fatal error detected, aborting.
02:42:06         

@0xc0170
Please restart test-job once the license issue is resolved.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 11, 2017

Please restart test-job once the license issue is resolved.

Thanks, will do

@studavekar please check the latest run here

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 11, 2017

/morph test-nightly

@mbed-bot
Copy link

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1565

Build Prep failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 11, 2017

I should run just build, but as it was already nightly, restarting. The license should be OK now

/morph test-nightly

@studavekar
Copy link
Contributor

studavekar commented Oct 11, 2017

morph nightly is replaced by #5252 (comment) , so change looks good i guess will update the other pending status.

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1566

Test failed!

@0xc0170 0xc0170 removed the needs: CI label Oct 12, 2017
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 12, 2017

@mikter @kjbracey-arm review?

Copy link

@mikter mikter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me @kjbracey-arm to approve

@mbed-ci
Copy link

mbed-ci commented Oct 12, 2017

@studavekar
Copy link
Contributor

please the failure the job was cancalled #5252 (comment)

actual result #5252 (comment)

@theotherjimmy theotherjimmy merged commit 2a57d59 into master Oct 13, 2017
@0xc0170 0xc0170 deleted the 6lowpan-enable-MPL branch June 27, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants