Skip to content

Add drivers and configuration for DISCO_L475VG_IOT01A target. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2019
Merged

Add drivers and configuration for DISCO_L475VG_IOT01A target. #15

merged 1 commit into from
Oct 4, 2019

Conversation

JammuKekkonen
Copy link
Contributor

Missing required Mbed-os 5.14 and bootloader.

@JammuKekkonen JammuKekkonen added the WIP Work in progress label Aug 26, 2019
yogpan01
yogpan01 suggested changes Aug 26, 2019
View reviewed changes
mbed_cloud_client_user_config.h Outdated
@@ -23,7 +23,12 @@
#define MBED_CLOUD_CLIENT_TRANSPORT_MODE_TCP
#define MBED_CLOUD_CLIENT_LIFETIME 3600

#ifdef TARGET_DISCO_L475VG_IOT01A
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to get rid of the flag and have this configuration of 256 as default for all the boards?
@teetak01 @anttiylitokola will this work for all the boards?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work fine

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Yogesh. Let's try to keep the configuration generic.
If you need a custom config for a specific target, please consider including in mbed_app.json (if possible).

teetak01
teetak01 reviewed Aug 26, 2019
View reviewed changes
drivers/wifi-ism43362.lib Outdated
@@ -0,0 +1 @@
https://github.com/ARMmbed/wifi-ism43362/#1c040113be0fe2a14c4b6107e1db3ec24e8b20b6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could rename this as COMPONENT_WIFI_ISM43362 like in PR #4

@MarceloSalazar
Copy link

@JammuKekkonen can you please make the suggested changes, so we can progress with the review & merge? Thanks!

@anttiylitokola
Copy link
Contributor

Can one of the admins verify this patch?

@JammuKekkonen
Copy link
Contributor Author

I'm working on this.

@JammuKekkonen
Copy link
Contributor Author

The updates are not working with this setup, due to the way rot might or might not get automatically generated. Need to change the config to external kvstore.

@teetak01 teetak01 mentioned this pull request Oct 2, 2019
Closed
@anttiylitokola anttiylitokola force-pushed the add_discol475vgiot01a_support branch from 369a754 to 6035829 Compare October 2, 2019 10:19
@anttiylitokola
Copy link
Contributor

run-ci

1 similar comment
@anttiylitokola
Copy link
Contributor

run-ci

@yogpan01
Copy link
Contributor

yogpan01 commented Oct 2, 2019

build-only

@JammuKekkonen JammuKekkonen force-pushed the add_discol475vgiot01a_support branch from 6035829 to 5950820 Compare October 3, 2019 12:21
@yogpan01
Copy link
Contributor

yogpan01 commented Oct 3, 2019

run-ci

@yogpan01 yogpan01 self-requested a review October 3, 2019 12:29
@teetak01 teetak01 mentioned this pull request Oct 3, 2019
Closed
@JammuKekkonen JammuKekkonen merged commit 9c6cc7e into master Oct 4, 2019
@JammuKekkonen JammuKekkonen deleted the add_discol475vgiot01a_support branch October 4, 2019 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarceloSalazar MarceloSalazar MarceloSalazar left review comments

@yogpan01 yogpan01 yogpan01 approved these changes

@teetak01 teetak01 teetak01 approved these changes

@anttiylitokola anttiylitokola Awaiting requested review from anttiylitokola

Assignees
No one assigned
Labels
new platform Requires CI WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JammuKekkonen @MarceloSalazar @anttiylitokola @yogpan01 @teetak01