add CY8CPROTO_062_4343W #37
Conversation
|
Can one of the admins verify this patch? |
mbed_app.json
Outdated
| @@ -33,7 +31,7 @@ | |||
| "lwip.mem-size" : 12500 | |||
| }, | |||
| "K64F": { | |||
| "target.macros_add" : ["MBEDTLS_USER_CONFIG_FILE=\"mbedTLSConfig_mbedOS.h\""], | |||
| "target.macros_add" : ["MBEDTLS_USER_CONFIG_FILE=\"mbedTLSConfig_mbedOS.h\"", "MBED_BOOTLOADER_SIZE=(32*1024)", "ARM_UC_USE_PAL_BLOCKDEVICE=1"], | |||
There was a problem hiding this comment.
It is better do this kind of changes as seperate PR, and target update PRs should only touch configuration directly relevant to that PR.
The bootload size part is already fixed in #15
mbed_app.json
Outdated
| }, | ||
| "CY8CPROTO_062_4343W": { | ||
| "target.extra_labels_add" : [ "PSA" ], | ||
| "target.macros_add" : ["MBEDTLS_USER_CONFIG_FILE=\"mbedTLSConfig_mbedOS.h\"", "MBED_BOOTLOADER_SIZE=(48*1024)", "ARM_UC_USE_PAL_BLOCKDEVICE=0"], |
There was a problem hiding this comment.
No need to defined the flag as zero, just do not define it at all.
| "storage_tdb_internal.internal_base_address": "0x100F0000", | ||
| "storage_tdb_internal.internal_size" : "0x00020000", | ||
| "storage.storage_type" : "TDB_INTERNAL", | ||
| "target.bootloader_supported" : true, |
There was a problem hiding this comment.
I would keep the similar configuration parameters groupped together.
maclobdell
force-pushed
the
add-cy8cproto-062-4343w
branch
from
fcca1e0 to
da06bdd
Compare
maclobdell
force-pushed
the
add-cy8cproto-062-4343w
branch
from
da06bdd to
f45582d
Compare
|
sorry for the long delay. I have rebased my branch and fixed the major issues. It now works without changing any of the common configurations. It is not optimized, but it does work. Please review. There is hardware in Oulu for testing. |
maclobdell
changed the title
There was a problem hiding this comment.
I will approve this tentatively.
Could you still rename the bootloader file + add new line to the README for this target with a Note in the last section:
"Build-only"
This effectively signifies that we only test the compilation for this target so far. We will remove the note after we get the board in CI.
|
run-ci |
Test run: FAILEDTest summary: Failed test cases: posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/ |
|
@maclobdell can you rebase and update this PR? |
|
I have made all the changes as requested. Sorry for the long delay. |
|
Closing this pull request as there is something corrupted in GitHub. When I update the branch it causes this pull request page to return a 500 error, which weirdly is fixed by pushing the branch directly on the repo instead of my fork. I will resubmit this PR. |
These changes add support for the Cypress PSoC6 Prototyping board (CY8CPROTO_062_4343) using internal flash for both kvstore an update storage.
Also as part of this pull request, some macro definitions are moved from global to target specific. This accommodates making the choice to put the update storage in internal flash.
Please note that there is still an outstanding issue with Mbed OS 5.14.0 that is being tracked by ARMmbed/mbed-os#10892. We are currently evaluating if PR ARMmbed/mbed-os#11542 fixes the issue.
Also, the bootloader may need to be re-built to try to make it smaller, so this is a work-in-process PR. Please review and add suggestions on requirements to get it merged.