Skip to content

Update for feature_cmsis5 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 24, 2017

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Apr 21, 2017

  • Switch from RTX to RTX2
  • Add EFM32GG support
  • Clean up a bit

@AlessandroA @niklas-arm

@Patater Patater changed the title Update for feature_cmsis5 WIP Update for feature_cmsis5 Apr 21, 2017
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 24, 2017

bump

@Patater Patater changed the title WIP Update for feature_cmsis5 Update for feature_cmsis5 Apr 24, 2017
Copy link

@AlessandroA AlessandroA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

mbed_app.json Outdated
@@ -3,6 +3,10 @@
"*": {
"target.features_add": ["UVISOR"],
"target.extra_labels_add": ["UVISOR_SUPPORTED"]
},
"EFM32GG_STK3700": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed anymore, because of the * in line 3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

mbed_app.json Outdated
},
"EFM32GG_STK3700": {
"target.features_add": ["UVISOR"],
"target.extra_labels_add": ["UVISOR_SUPPORTED"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify test/filters.json as well (remove EFM32GG_STK3700 from the blacklist).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

niklarm and others added 4 commits April 24, 2017 10:59
mbed OS has been updated and we no longer need to provide the backwards
compatibility `ifdef` guard. Remove the `ifdef` guard as unnecessary.
Add support for building with RTX2, breaking compatibility with the
previous version of RTX.
Copy link

@AlessandroA AlessandroA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlessandroA
Copy link

retest uvisor

@AlessandroA AlessandroA merged commit 0e8fa8a into ARMmbed:feature_cmsis5 Apr 24, 2017
@Patater Patater mentioned this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants