Skip to content

Add code snippet for UnbufferedSerial and BufferedSerial API documentation #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2020
Merged

Add code snippet for UnbufferedSerial and BufferedSerial API documentation #66

merged 1 commit into from
Feb 10, 2020

Conversation

hugueskamba
Copy link
Contributor

@hugueskamba hugueskamba commented Feb 5, 2020 •
edited
Loading

The code snippets are to be referenced in the API documentation for the classes.

Update ARMmbed/mbed-os-5-docs#1220 after merging!

@hugueskamba hugueskamba force-pushed the hk-add-unbuffered-snipets branch from 9795f48 to a9045f0 Compare February 5, 2020 15:08
@hugueskamba hugueskamba mentioned this pull request Feb 5, 2020
Merged
@hugueskamba hugueskamba force-pushed the hk-add-unbuffered-snipets branch from a9045f0 to ae3b3b4 Compare February 6, 2020 08:05
evedon
evedon reviewed Feb 6, 2020
View reviewed changes
Copy link

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions.

evedon
evedon reviewed Feb 6, 2020
View reviewed changes
@hugueskamba hugueskamba force-pushed the hk-add-unbuffered-snipets branch 2 times, most recently from d7dba9c to 6d0e304 Compare February 6, 2020 15:15
@hugueskamba hugueskamba changed the title Add code snippet for UnbufferedSerial API documentation Add code snippet for UnbufferedSerial and BufferedSerial API documentation Feb 6, 2020
@hugueskamba hugueskamba force-pushed the hk-add-unbuffered-snipets branch 2 times, most recently from 2b0d966 to dd81220 Compare February 7, 2020 08:34
evedon
evedon reviewed Feb 7, 2020
View reviewed changes
@hugueskamba hugueskamba force-pushed the hk-add-unbuffered-snipets branch 2 times, most recently from 17b7244 to 69e8c2e Compare February 8, 2020 14:38
jamesbeyond
jamesbeyond suggested changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing on building APIS_DRIVERS\BUFFEREDSERIAL_ECHO, please check

@hugueskamba
Copy link
Contributor Author

hugueskamba commented Feb 10, 2020 •
edited
Loading

CI is failing on building APIS_DRIVERS\BUFFEREDSERIAL_ECHO, please check

@jamesbeyond
There was a PR to fix Mbed OS. It should work now. The CI has been restarted.

@hugueskamba hugueskamba force-pushed the hk-add-unbuffered-snipets branch from 69e8c2e to 60ca0c2 Compare February 10, 2020 12:14
@jamesbeyond jamesbeyond merged commit c36d9fe into ARMmbed:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

@evedon evedon evedon approved these changes

@jamesbeyond jamesbeyond jamesbeyond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugueskamba @0xc0170 @evedon @jamesbeyond