Skip to content

Fix BufferedSerial visibility of private base class enum enumerators #12382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

Each enum enumerator needs to be exposed to be usable in the sub class.

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @kjbracey-arm @0xc0170


Each enum enumerator needs to be exposed to be usable in the sub class.
@ciarmcom ciarmcom requested review from 0xc0170, evedon, kjbracey and a team February 6, 2020 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 6, 2020

@hugueskamba, thank you for your changes.
@0xc0170 @kjbracey-arm @evedon @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was checking this while ago, I did not understand the previous comment about C++1x and not needed using there. @kjbracey-arm Please review

@kjbracey
Copy link
Contributor

kjbracey commented Feb 7, 2020

I was checking this while ago, I did not understand the previous comment about C++1x and not needed using there. @kjbracey-arm Please review

It seems I was wrong when I wrote that comment in the original code. Something had led me to believe that using a plain enum also gave you its values in C++11, but I can now find no reference to that, nor can I figure out what I might have misinterpreted.

Maybe it was something to do with C++11 enum classes - they would naturally give you Parity::Even if you did using SerialBase::Parity.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 7, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 7, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 7, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge
Copy link
Contributor

@hugueskamba @0xc0170 is this exposing new API parts ? In which case it should be feature update?

@hugueskamba hugueskamba deleted the hk-fix-bufferedserial-exposed-enums branch June 30, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants