Skip to content

Add Cypress kits to platform database #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Add Cypress kits to platform database #110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d1519c
Add Cypress kits to platform database
vmedcy Jan 22, 2019
8286dce
Merge branch 'master' into add_cypress_kits
bridadan Jan 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/mbed_os_tools/detect/platform_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,13 @@
u"1701": u"GD32_F307VG",
u"1702": u"GD32_F450ZI",
u"1703": u"GD32_E103VB",
u'1900': u'CY8CKIT_062_WIFI_BT',
u'1901': u'CY8CPROTO_062_4343W',
u'1902': u'CY8CKIT_062_BLE',
u'1903': u'CY8CPROTO_062_43012',
u'1904': u'CY8CPROTO_063_BLE',
u'1905': u'CY8CKIT_062_4343W',
u'1906': u'CYW943012P6EVB_01',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ids all accounted for! One little oddity: I noticed the following platforms have slightly different names in the database, just wondering if that was intentional:

  • CY8CPROTO_062_43012 - CYPROTO-062-43012 (does not have the 8C part after CY)
  • CY8CPROTO_063_BLE - CYPROTO-063-BLE (does not have the 8C part after CY)
  • CY8CKIT_062_4343W - CY8CKIT-062-WiFi-BT-F (quite a different suffix)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bridadan: the names in this PR are correct, the update was sent to Mac today.

@maclobdell: can you confirm once the internal board database is updated?

All Cypress boards follow the consistent naming convention:

CY8CKIT - Pioneer Kit (with Arduino headers)
CY8CPROTO - Prototyping Kit (low-cost baseboard with connectivity module)
CY8CMOD - Connectivity module

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. Once the database is updated we can get this merged! It's mostly just for our own record keeping, but I'd like to keep them consistent.

u"2000": u"EFM32_G8XX_STK",
u"2005": u"EFM32HG_STK3400",
u"2010": u"EFM32WG_STK3800",
Expand Down