Skip to content

Reduce 32KB from LPC55S69_S binary size #10047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Reduce 32KB from LPC55S69_S binary size #10047

merged 2 commits into from
Mar 13, 2019

Conversation

mikisch81
Copy link
Contributor

Description

Reduce the LPC55S69_S targets binary size from 192KB to 160KB.

Tested on LPC55S69 target, all PSA and compliance tests pass.

Targeted for rc3.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@orenc17 @mmahadevan108

Release Notes

@ciarmcom
Copy link
Member

@mikisch81, thank you for your changes.
@orenc17 @maclobdell @MarceloSalazar @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@mmahadevan108
Copy link
Contributor

Thank you for your changes, please update the below as well as I could not find a way to include the header file into IAR linker script as is done for GCC_ARM and ARMC toolchains
https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_M33_NS/device/TOOLCHAIN_IAR/LPC55S69_cm33_core0_flash.icf#L26

@mikisch81
Copy link
Contributor Author

@theotherjimmy @bridadan @deepikabhavnani @orenc17 @alzix
Opened IOTSEC-1123 regarding our on-going discussion on PSA targets addresses.

This PR is an example of the need for it (a small change in the split between secure/non-secure forced us to change couple of files).

Copy link
Contributor

@alzix alzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use values from JSON file directly instead of hardcoded values?

@mikisch81
Copy link
Contributor Author

Can we use values from JSON file directly instead of hardcoded values?

It is something which requires more work, can you move the discussion to the new JIRA task?

@mikisch81
Copy link
Contributor Author

@jenia81 @mottigondabi FYI

@mikisch81
Copy link
Contributor Author

@orenc17 please review

@0xc0170 0xc0170 requested a review from a user March 13, 2019 09:48
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 13, 2019

CI started

@orenc17
Copy link
Contributor

orenc17 commented Mar 13, 2019

rebased on top of master for #10086

@mikisch81
Copy link
Contributor Author

@0xc0170 can CI be restarted?

@orenc17
Copy link
Contributor

orenc17 commented Mar 13, 2019

@mikisch81 i think we are going to need a roll-up PR here @davidsaada has conflicts between this PR and #10086 and #10068

@mikisch81
Copy link
Contributor Author

@orenc17 this PR is ready to be merged, it was only waiting for rc2 to finally happen, no need to hold this because of another PR

@cmonr
Copy link
Contributor

cmonr commented Mar 13, 2019

@mikisch81 i think we are going to need a roll-up PR here @davidsaada has conflicts between this PR and #10086 and #10068

Oh boy.

@davidsaada
Copy link
Contributor

No need for a rollup PR. My bootloader PR is dependent on this one and not vice versa. All I needed was either this PR to be merged in or rebased.

@cmonr
Copy link
Contributor

cmonr commented Mar 13, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 13, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@mbed-ci
Copy link

mbed-ci commented Mar 13, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit fe59870 into ARMmbed:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants