-
Notifications
You must be signed in to change notification settings - Fork 3k
Reduce 32KB from LPC55S69_S binary size #10047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mikisch81, thank you for your changes. |
Thank you for your changes, please update the below as well as I could not find a way to include the header file into IAR linker script as is done for GCC_ARM and ARMC toolchains |
@theotherjimmy @bridadan @deepikabhavnani @orenc17 @alzix This PR is an example of the need for it (a small change in the split between secure/non-secure forced us to change couple of files). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use values from JSON file directly instead of hardcoded values?
It is something which requires more work, can you move the discussion to the new JIRA task? |
@jenia81 @mottigondabi FYI |
@orenc17 please review |
CI started |
rebased on top of master for #10086 |
@0xc0170 can CI be restarted? |
@mikisch81 i think we are going to need a roll-up PR here @davidsaada has conflicts between this PR and #10086 and #10068 |
@orenc17 this PR is ready to be merged, it was only waiting for rc2 to finally happen, no need to hold this because of another PR |
Oh boy. |
No need for a rollup PR. My bootloader PR is dependent on this one and not vice versa. All I needed was either this PR to be merged in or rebased. |
CI started |
Test run: FAILEDSummary: 1 of 13 test jobs failed Failed test jobs:
|
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
Description
Reduce the LPC55S69_S targets binary size from 192KB to 160KB.
Tested on LPC55S69 target, all PSA and compliance tests pass.
Targeted for rc3.
Pull request type
Reviewers
@orenc17 @mmahadevan108
Release Notes