LPC55S69: Add IAR and uvision exporter support #10068

mmahadevan108 · 2019-03-12T17:37:39Z

Description

Add IAR and uvision exporter support for LPC55S69

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@orenc17 @theotherjimmy @mikisch81 @maclobdell

mmahadevan108 · 2019-03-12T17:40:35Z

Depends on #9994

mikisch81 · 2019-03-12T17:41:45Z

@Alonof @mottigondabi FYI

mikisch81 · 2019-03-12T17:45:28Z

@ARMmbed/mbed-os-maintainers can it be rc3? It will significantly help debugging Pelion client integration.

ciarmcom · 2019-03-12T18:00:38Z

@mmahadevan108, thank you for your changes.
@mikisch81 @maclobdell @theotherjimmy @orenc17 @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

mikisch81 · 2019-03-12T19:59:32Z

I tried it on my Windows machine and got this when trying to build the target:

*** Using Compiler 'V6.10.1', folder: 'C:\Keil_v5\ARM\ARMCompiler6.10.1\Bin'
Build target 'mbed_app'
compiling ac_buffer.c...
armclang.exe: error: no such file or directory: 'target'
armclang.exe: error: no such file or directory: 'not'
armclang.exe: error: no such file or directory: 'found'

Ran mbed export -i uvision6 -m LPC55S69_NS --profile debug

bridadan

Changes look fine to me!

theotherjimmy

Changes look good. Sorry that my last CPM sync missed that device pack download. Could you comment on how uvision re-implements the same post-build script?

theotherjimmy · 2019-03-12T22:53:50Z

@mikisch81 You're missing the Device Family Pack. It should have prompted for install when you opened the project.

0xc0170 · 2019-03-13T09:46:25Z

@ARMmbed/mbed-os-maintainers can it be rc3? It will significantly help debugging Pelion client integration.

5.12.0-rc3 label added, waiting for approvals

mmahadevan108 · 2019-03-13T13:41:43Z

@theotherjimmy . The Target section is not set correctly in the project generated by exporter.

When I switch to a different device and come back to LPC55S69, then the target section gets updated with the right value:

Can you take a look at the exporter code.

theotherjimmy · 2019-03-13T14:11:42Z

tools/arm_pack_manager/index.json

+                "startup": false
+            }
+        },
+        "name": "LPC55S69JBD100:cm33_core0",


This was not generated by CPM. please use the definition from CPM

If do not use this name then the device selection is not made. When I set the name to this value, then it make the right device selection.

We can do this another way without manually editing the index. I'll have comments on how soon.

I recommend:

diff --git a/tools/arm_pack_manager/index.json b/tools/arm_pack_manager/index.json index 04099199fc..0e444f5400 100644 --- a/tools/arm_pack_manager/index.json +++ b/tools/arm_pack_manager/index.json @@ -157095,7 +157095,7 @@ "startup": false } }, - "name": "LPC55S69JBD100:cm33_core0", + "name": "LPC55S69JBD100", "processor": { "Asymmetric": { "cm33_core0": { @@ -462779,4 +462779,4 @@ "vendor": "Nordic Semiconductor:54" }, "version": "0.2.0" -} \ No newline at end of file +} diff --git a/tools/export/cmsis/__init__.py b/tools/export/cmsis/__init__.py index f4e4d94a18..0248c4f72e 100644 --- a/tools/export/cmsis/__init__.py +++ b/tools/export/cmsis/__init__.py @@ -51,10 +51,12 @@ class DeviceCMSIS(): try: self.dfpu = target_info['processor']['Symmetric']['fpu'] except KeyError: - cmsis_core = self.core.replace("F", "").replace("-", "") - for proc in target_info['processor']['Asymmetric'].values(): + cmsis_core = self.core.replace("F", "").replace("-", "").replace("E", "") + for core_name, proc in target_info['processor']['Asymmetric'].items(): if proc['core'] == cmsis_core: self.dfpu = proc['fpu'] + self.dname = '{}:{}'.format(self.dname, core_name) + break self.debug, self.dvendor = self.vendor_debug( target_info.get('vendor') or target_info['from_pack']['vendor'] )

I verified that this procudes the same LPC55S69JBD100:cm33_core0 string in the project file.

Great thank you, I will update the name. Please help check the other issue with memory section.

This change does not seem to be working

- self.dfpu = target_info['processor']['Asymmetric']['fpu'] + cmsis_core = self.core.replace("F", "").replace("-", "").replace("E", "") + for core_name, proc in target_info['processor']['Asymmetric'].items(): + if proc['core'] == cmsis_core: + self.dfpu = proc['fpu'] + self.dname = '{}:{}'.format(self.dname, core_name) + break + print(self.dname)

PS C:\mbed-os-example-blinky> mbed export -i uvision6 -m LPC55S69_NS
[mbed] Working path "C:\mbed-os-example-blinky" (program)
Scan: mbed-os-example-blinky
LPC55S69JBD100
LPC55S69JBD100

👍 Good catch, I was uisng the _S variant. New patch below:

diff --git a/tools/arm_pack_manager/index.json b/tools/arm_pack_manager/index.json index 04099199fc..0e444f5400 100644 --- a/tools/arm_pack_manager/index.json +++ b/tools/arm_pack_manager/index.json @@ -157095,7 +157095,7 @@ "startup": false } }, - "name": "LPC55S69JBD100:cm33_core0", + "name": "LPC55S69JBD100", "processor": { "Asymmetric": { "cm33_core0": { @@ -462779,4 +462779,4 @@ "vendor": "Nordic Semiconductor:54" }, "version": "0.2.0" -} \ No newline at end of file +} diff --git a/tools/export/cmsis/__init__.py b/tools/export/cmsis/__init__.py index f4e4d94a18..a4569122b5 100644 --- a/tools/export/cmsis/__init__.py +++ b/tools/export/cmsis/__init__.py @@ -51,10 +51,14 @@ class DeviceCMSIS(): try: self.dfpu = target_info['processor']['Symmetric']['fpu'] except KeyError: - cmsis_core = self.core.replace("F", "").replace("-", "") - for proc in target_info['processor']['Asymmetric'].values(): + # TODO: refactor this into a "base_core_for" function + cmsis_core = self.core.replace("F", "").replace("-", "").replace("E", "") + cmsis_core = cmsis_core.replace("NS", "") + for core_name, proc in target_info['processor']['Asymmetric'].items(): if proc['core'] == cmsis_core: self.dfpu = proc['fpu'] + self.dname = '{}:{}'.format(self.dname, core_name) + break self.debug, self.dvendor = self.vendor_debug( target_info.get('vendor') or target_info['from_pack']['vendor'] )

Thanks this works. The Device Tab of the Project Options is set correctly. The Target Tab of the Properties is not correct.

It's a start. I'll look into what it would take to set the Target Tab correctly.

mmahadevan108 · 2019-03-13T14:45:33Z

Can you please clarify how the memories section is picked from index.json and populated into the uvision.tmpl file?

theotherjimmy · 2019-03-13T14:55:23Z

@mmahadevan108 I'd have to look into that. I don't know off the top of my head.

theotherjimmy · 2019-03-13T15:15:28Z

@mmahadevan108 I can't get uvision6 to export locally for LPC55S69 (_S or _NS), how do you get an export?

mmahadevan108 · 2019-03-13T15:18:03Z

You have to apply the patch from #9994

mmahadevan108 · 2019-03-13T15:19:04Z

mbed export -i uvision6 -m LPC55S69_NS

theotherjimmy · 2019-03-13T15:24:09Z

@mmahadevan108 I have rebased your branch on top of #9994, and I still can't get an export going.

theotherjimmy · 2019-03-13T15:31:16Z

Got it working, Had to rebase onto master again.

0xc0170 · 2019-03-14T09:25:25Z

CI started

mbed-ci · 2019-03-14T12:09:14Z

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter

Signed-off-by: Mahesh Mahadevan <[email protected]>

0xc0170 · 2019-03-14T12:20:48Z

License issue , @ARMmbed/mbed-os-test ^^

Once we fix this, test will be restarted

Signed-off-by: Mahesh Mahadevan <[email protected]>

0xc0170 · 2019-03-14T12:26:59Z

@mmahadevan108 what's the latest push ? Will restart CI once confirmed this is ready

mmahadevan108 · 2019-03-14T12:28:06Z

It includes the below commit per suggestion from @theotherjimmy.
3da7c6f

mmahadevan108 · 2019-03-14T12:30:28Z

@mikisch81 For the build issue, please pick a different device and then re-select the LPC55S69. This operation populates the right memory values.
This is a temporary fix till the memory section is properly populated.

mmahadevan108 · 2019-03-14T12:43:43Z

@0xc0170 . This PR is ready

0xc0170 · 2019-03-14T12:52:05Z

CI started

theotherjimmy · 2019-03-14T15:00:09Z

@mmahadevan108 ~~Could you post the <OnChipMemories> tree from the project after the workaroud?~~ On second thought, we should have an issue for this, and @bridadan or @aashishc1988 and I can look into the incorrect memory stuff (the current template hard codes those values 😱)

theotherjimmy

We're good to go now.

mmahadevan108 · 2019-03-14T15:16:24Z

@mmahadevan108 Could you post the <OnChipMemories> tree from the project after the workaroud? On second thought, we should have an issue for this, and @bridadan or @aashishc1988 and I can look into the incorrect memory stuff (the current template hard codes those values 😱)

Here is the difference. The original project file has the below for CPU.
<Cpu>CPUTYPE("Cortex-M33FE") </Cpu>
The working version has the below:

      <Cpu>IRAM(0x20000000,0x044000) IRAM2(0x04000000,0x8000) IROM(0x00000000,0x098000) XRAM(0x40100000,0x4000) CPUTYPE("Cortex-M33") FPU3(SFPU) DSP TZ CLOCK(12000000) ELITTLE</Cpu>

mmahadevan108 · 2019-03-14T15:20:23Z

@mmahadevan108 Could you post the <OnChipMemories> tree from the project after the workaroud? On second thought, we should have an issue for this, and @bridadan or @aashishc1988 and I can look into the incorrect memory stuff (the current template hard codes those values 😱)

#10103

mbed-ci · 2019-03-14T15:42:56Z

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter

mmahadevan108 · 2019-03-14T15:51:14Z

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter

No idea on the failure. Seems unrelated to this PR

0xc0170 · 2019-03-14T15:52:25Z

I reported this to @ARMmbed/mbed-os-test . Will restart exporters

NirSonnenschein · 2019-03-14T15:53:05Z

unexplained error (possibly license issue)
16:44:23 16:44:23 [UBLOX_EVK_ODIN_W2:make_armc6] Error: hudson.AbortException: script returned exit code 1
restarting exporters

cmonr · 2019-03-14T18:27:06Z

armclang: error: Failed to check out a license.

Exporter job restarted.

cmonr · 2019-03-15T03:29:05Z

CI failures still seem incredibly suspicious.

Restarting CI completely.

mbed-ci · 2019-03-15T05:27:47Z

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter

0xc0170 · 2019-03-15T06:58:50Z

I restarted exporters the very last time (license server issue)

mikisch81 mentioned this pull request Mar 12, 2019

Correct FPU settings traceback found by IAR #9994

Merged

ciarmcom requested review from maclobdell, mikisch81, orenc17, theotherjimmy and a team March 12, 2019 18:00

ciarmcom added the needs: review label Mar 12, 2019

bridadan approved these changes Mar 12, 2019

View reviewed changes

theotherjimmy approved these changes Mar 12, 2019

View reviewed changes

0xc0170 requested a review from a user March 13, 2019 09:45

0xc0170 added the release-version: 5.12.0-rc3 label Mar 13, 2019

0xc0170 added the needs: preceding PR label Mar 13, 2019

theotherjimmy suggested changes Mar 13, 2019

View reviewed changes

orenc17 mentioned this pull request Mar 13, 2019

Reduce 32KB from LPC55S69_S binary size #10047

Merged

davidsaada mentioned this pull request Mar 14, 2019

Add bootloader support for the LPC55S69 board #10086

Merged

LPC55S69: Add IAR and uvision exporter support

83eed9e

Signed-off-by: Mahesh Mahadevan <[email protected]>

Update to provide the right device name in the Asymmetric case

3da7c6f

Signed-off-by: Mahesh Mahadevan <[email protected]>

mmahadevan108 force-pushed the Add_LPC55S96_Exporter_Support branch from f733205 to 3da7c6f Compare March 14, 2019 12:25

theotherjimmy approved these changes Mar 14, 2019

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Mar 15, 2019

0xc0170 merged commit cde7d0b into ARMmbed:master Mar 15, 2019

0xc0170 removed the ready for merge label Mar 15, 2019

mmahadevan108 deleted the Add_LPC55S96_Exporter_Support branch March 15, 2019 18:19

0xc0170 mentioned this pull request Mar 19, 2019

LPC55S69 IAR build has conflicting RAM/ROM defines #10153

Closed

LPC55S69: Add IAR and uvision exporter support #10068

LPC55S69: Add IAR and uvision exporter support #10068

Uh oh!

Conversation

mmahadevan108 commented Mar 12, 2019

Description

Pull request type

Reviewers

Uh oh!

mmahadevan108 commented Mar 12, 2019

Uh oh!

mikisch81 commented Mar 12, 2019

Uh oh!

mikisch81 commented Mar 12, 2019

Uh oh!

ciarmcom commented Mar 12, 2019

Uh oh!

mikisch81 commented Mar 12, 2019

Uh oh!

bridadan left a comment

Choose a reason for hiding this comment

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

theotherjimmy commented Mar 12, 2019

Uh oh!

0xc0170 commented Mar 13, 2019

Uh oh!

mmahadevan108 commented Mar 13, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mmahadevan108 Mar 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theotherjimmy Mar 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mmahadevan108 commented Mar 13, 2019

Uh oh!

theotherjimmy commented Mar 13, 2019

Uh oh!

theotherjimmy commented Mar 13, 2019

Uh oh!

mmahadevan108 commented Mar 13, 2019

Uh oh!

mmahadevan108 commented Mar 13, 2019

Uh oh!

theotherjimmy commented Mar 13, 2019

Uh oh!

theotherjimmy commented Mar 13, 2019

Uh oh!

0xc0170 commented Mar 14, 2019

Uh oh!

mbed-ci commented Mar 14, 2019

Uh oh!

0xc0170 commented Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Mar 14, 2019

Uh oh!

mmahadevan108 commented Mar 14, 2019

Uh oh!

mmahadevan108 commented Mar 14, 2019

Uh oh!

mmahadevan108 Mar 13, 2019 •

edited

Loading

theotherjimmy Mar 13, 2019 •

edited

Loading

0xc0170 commented Mar 14, 2019 •

edited

Loading

theotherjimmy commented Mar 14, 2019 •

edited

Loading

mmahadevan108 commented Mar 14, 2019 •

edited

Loading