Fix for reallocation memory fail in TMPM46B #10048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
@ganesh-ramachandran, thank you for your changes. |
|
I just found the issue, I don't feel comfortable reviewing HAL code. |
|
the fix is fine. |
0xc0170
approved these changes
Mar 13, 2019
0xc0170
added
needs: CI
release-version: 5.12.1
rollup PR
and removed
needs: review
labels
|
No more changes are expected there. This was added to the rollup PR #10097 and it's currently in CI. If any new commit comes, please let us know immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
'gI2C_LTxData' is reallocated but the return value is not checked. If this fails it could lead to writing in uninitialized memory. Hence error check added if reallocation fails.
Pull request type
Reviewers
@janjongboom
Reference
PR #9987