Skip to content

Rollup PRs: simple fixes #10097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 15, 2019
Merged

Rollup PRs: simple fixes #10097

merged 18 commits into from
Mar 15, 2019

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Mar 14, 2019

Description

This is rollup PR for the following PRs:

#10073
#9925
#9930
#9965
#9972
#9979
#9980
#9985
#10048

Most of them are simple fixes (one liners or one file).

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

janjongboom and others added 18 commits March 4, 2019 11:16
This PR: ARMmbed@3bd3aca#diff-995cd6fe18f4fabfb549266dde0a3784 broke the SAML21J18A target, as there was no `#if DEVICE_ANALOGOUT` call, and this PR added an `#endif` there that's not matched now.
`pscrk` is set to the address of `csrk`, but `csrk` is out of scope when using the resulting value. There's no guarantee that the memory is still valid.
@0xc0170 0xc0170 changed the title Rollup Prs: simple fixes together Rollup PRs: simple fixes Mar 14, 2019
@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 14, 2019

CI started

Copy link
Contributor

@NirSonnenschein NirSonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 14, 2019

aborted t he rest of pipeline for rc3 jobos, will restart

@mbed-ci
Copy link

mbed-ci commented Mar 14, 2019

Test run: FAILED

Summary: 4 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_exporter
  • jenkins-ci/mbed-os-ci_greentea-test

@cmonr
Copy link
Contributor

cmonr commented Mar 15, 2019

Resumed CI

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 15, 2019

Pipeline was not restarted properly, but everything completed and green, cc @ARMmbed/mbed-os-test

@0xc0170 0xc0170 merged commit 0e37fc2 into ARMmbed:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants