Fix undefined tr_debug for QUECTEL_BG96 cellular feature #9965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sarahmarshy, thank you for your changes. |
jarvte
suggested changes
Mar 7, 2019
| @@ -30,6 +30,8 @@ using namespace events; | |||
|
|
|||
| #define DEVICE_READY_URC "CPIN:" | |||
|
|
|||
| #define tr_debug(...) | |||
There was a problem hiding this comment.
Please remove this and include the correct header:
#include "CellularLog.h"
There was a problem hiding this comment.
Just curious, for what purpose CellularLog is? can’t mbed_trace include be used directly here?
There was a problem hiding this comment.
It defines trace group. There was other reasons in older mbed-os versions.
sarahmarshy
force-pushed
the
tr-debug-cell
branch
from
c1d3d8c to
b89d258
Compare
sarahmarshy
force-pushed
the
tr-debug-cell
branch
from
b89d258 to
ae45096
Compare
jarvte
approved these changes
Mar 9, 2019
0xc0170
approved these changes
Mar 14, 2019
|
No more changes are expected there. This was added to the rollup PR #10097 and it's currently in CI. If any new commit comes, please let us know immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Define
tr_debugfunction in QUECTEL_BG96 cellular featurePull request type