Add baremetal example to testing #10131

kegilbert · 2019-03-17T02:01:28Z

Description

Add a basic baremetal blinky example to the test framework to get a smoketest of baremetal (currently have none in CI). @bulislaw Does this look like a more reasonable solution than modifying blinky?

@cmonr Should bare-metal be in 5.11.5? It was merged a couple of weeks before that release branch was made but I don't see it in there. I can either remove the bare-metal build profile from the example until the example is updated to 5.12 or point to a RC branch for the example's mbed-os hash. I wasn't 100% on the examples policy on what we can point to.
See Martin's reply: #10131 (comment)

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@bulislaw @SenRamakri

Release Notes

ciarmcom · 2019-03-17T04:00:26Z

@kegilbert, thank you for your changes.
@SenRamakri @bulislaw @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

0xc0170 · 2019-03-18T07:55:47Z

Baremetal is part of 5.12.
Point to mbed-os-5.12 branch now.

One note about naming - shouldn't be baremetal as suffix (blinky-baremetal) rather?

kegilbert · 2019-03-18T13:51:31Z

@0xc0170 Updated the example names and pointed to the Mbed OS 5.12 branch.

cmonr · 2019-03-18T18:41:51Z

CI started

cmonr · 2019-03-18T19:36:13Z

@kegilbert Plz fix, k thx.

mbed-ci · 2019-03-18T19:54:00Z

Test run: FAILED

Summary: 4 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARMC5
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR8
jenkins-ci/mbed-os-ci_build-ARMC6

kegilbert · 2019-03-18T21:04:30Z

@cmonr Limited the list of targets to ignore boards that are not built for Mbed OS 2 (mainly targets that were pulling in WifiInterface files that required RTOS classes).

cmonr · 2019-03-18T23:10:33Z

CI started

mbed-ci · 2019-03-19T01:22:43Z

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter

cmonr · 2019-03-19T01:44:53Z

CI job restarted: jenkins-ci/mbed-os-ci_exporter

Hate it when an exporter job fails because the JVM threw a fit (gnuarmeclipse ide).

0xc0170 · 2019-03-19T08:55:46Z

Exporters restarted again

0xc0170 · 2019-03-19T11:07:39Z

Exporters failing for multiple boards and 2nd time, please review

bulislaw

That's confusing. Well not these changes but the new example. There's not explanation what it illustrates and why is it there. We should at least add a description for external users saying what does it do and what's bare metal (with link to docs).

kegilbert · 2019-03-19T15:21:31Z

I'm touching up some of the baremetal/migration guide docs. I'm planning on adding a blurb there pointing to this is an out of the box baremetal example.

cmonr · 2019-03-19T20:32:31Z

@kegilbert You might need to take a look at the failure logs.

There might be problem with the PR/targets after all:
https://mbed-os.mbedcloudtesting.com/blue/rest/organizations/jenkins/pipelines/mbed-os-ci_exporter-gnuarmeclipse/runs/1787/nodes/46/log/?start=0

kegilbert · 2019-03-19T21:19:21Z

Don't seem to have access to that link @cmonr.
https://mbed-os.mbedcloudtesting.com/blue/organizations/jenkins/mbed-os-ci_exporter/detail/mbed-os-ci_exporter/1585/pipeline/17 isn't giving me much info, is there another link I could use?

kegilbert · 2019-03-21T16:08:33Z

@theotherjimmy ~~What would be the path forward in this case? Is this something fixable in a reasonable time-frame or something for a later release?~~

We spoke offline, it sounds like a fundamental limitation in gnuarmeclipse requiring a large amount of effort to update in our tools. Proposed path forward is to remove gnuarmeclipse testing for this example, update the docs to reflect that baremetal does not currently work in gnuarmeclipse, and throw a warning in the tools when a baremetal project is exported for the contemptuous IDE.

(@0xc0170 @bulislaw)

theotherjimmy · 2019-03-21T18:06:33Z

@kegilbert I'm not sure that I can fix this in a short order, because I don't know how I would fix this. I would expect this to take > 1day of work (which is all we have left before RC4)

0xc0170 · 2019-03-22T05:22:21Z

Proposed path forward is to remove gnuarmeclipse testing for this example

It has not been updated, neither any PR referencing this one. This might not be in rc4 if it does not get an update within next few hours.

adbridge · 2019-03-22T11:16:41Z

@kegilbert @theotherjimmy Could you not just add the list of exporters that do work to the exporters list in examples.json ? Though that would obviously only help our internal testing.

@kegilbert BTW you will need to talk to @screamerbg to get this example mirrored to os.mbed.com.....

baremetal does not currently work with gnuarmeclipse

kegilbert · 2019-03-22T14:19:41Z

Apologies for the delay, updated the exporter list and updated the OS teams example @adbridge
https://os.mbed.com/teams/mbed-os-examples/code/mbed-os-example-blinky-baremetal

0xc0170 · 2019-03-22T14:34:36Z

CI restarted

mbed-ci · 2019-03-22T16:40:05Z

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_exporter

adbridge · 2019-03-22T16:55:12Z

@kegilbert still failing exporters by the looks of it :(

adbridge · 2019-03-22T16:59:01Z

Bumping this out to 5.12.1

kegilbert · 2019-03-22T17:09:40Z

It's failing for uvision6 on the LPC55S69_NS, which is not a target included in my list for the baremetal example. Any idea why that one would be failing?

bridadan · 2019-03-22T18:29:10Z

Oh hey that target is failing on my PR as well: #10193

cmonr · 2019-03-26T02:49:08Z

CI restarted.
Complete restart needed since master's HEAD has moved, meaning CI needs to run against a new /ref/pull/*/merge reference

mbed-ci · 2019-03-26T06:19:27Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 5
Build artifacts

…ples-test Add baremetal example to testing

kegilbert force-pushed the baremetal-blinky-examples-test branch from ec6564f to 0abe178 Compare March 17, 2019 02:02

ciarmcom requested review from bulislaw, SenRamakri and a team March 17, 2019 04:00

ciarmcom added the needs: review label Mar 17, 2019

kegilbert force-pushed the baremetal-blinky-examples-test branch from 0abe178 to 6139b01 Compare March 18, 2019 13:46

kegilbert force-pushed the baremetal-blinky-examples-test branch from 6139b01 to 288d339 Compare March 18, 2019 21:03

cmonr approved these changes Mar 18, 2019

View reviewed changes

cmonr added release-version: 5.12.0-rc3 needs: CI and removed needs: review labels Mar 18, 2019

0xc0170 added needs: work and removed needs: CI labels Mar 19, 2019

bulislaw reviewed Mar 19, 2019

View reviewed changes

Remove gnuarmeclipse from baremetal export testing

ac2a52a

baremetal does not currently work with gnuarmeclipse

theotherjimmy approved these changes Mar 22, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Mar 22, 2019

adbridge added needs: work and removed needs: CI labels Mar 22, 2019

adbridge added release-version: 5.12.1 and removed release-version: 5.12.0-rc4 labels Mar 22, 2019

This was referenced Mar 22, 2019

Fallback to ARMC5 when ARMC6 is not configured #10193

Merged

Fix the removal of Mbed-added core flags in uvision exporter #10199

Merged

cmonr added needs: CI and removed needs: work labels Mar 26, 2019

NirSonnenschein added ready for merge and removed needs: CI labels Mar 26, 2019

cmonr pushed a commit to cmonr/mbed-os that referenced this pull request Mar 26, 2019

Merge pull request ARMmbed#10131 from kegilbert/baremetal-blinky-exam…

b1ee695

…ples-test Add baremetal example to testing

cmonr merged commit c2e5a8b into ARMmbed:master Mar 27, 2019

cmonr removed the ready for merge label Mar 27, 2019

Add baremetal example to testing #10131

Add baremetal example to testing #10131

Uh oh!

Conversation

kegilbert commented Mar 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Release Notes

Uh oh!

ciarmcom commented Mar 17, 2019

Uh oh!

0xc0170 commented Mar 18, 2019

Uh oh!

kegilbert commented Mar 18, 2019

Uh oh!

cmonr commented Mar 18, 2019

Uh oh!

cmonr commented Mar 18, 2019

Uh oh!

mbed-ci commented Mar 18, 2019

Test run: FAILED

Uh oh!

kegilbert commented Mar 18, 2019

Uh oh!

cmonr commented Mar 18, 2019

Uh oh!

mbed-ci commented Mar 19, 2019

Test run: FAILED

Uh oh!

cmonr commented Mar 19, 2019

Uh oh!

0xc0170 commented Mar 19, 2019

Uh oh!

0xc0170 commented Mar 19, 2019

Uh oh!

bulislaw left a comment

Choose a reason for hiding this comment

Uh oh!

kegilbert commented Mar 19, 2019

Uh oh!

cmonr commented Mar 19, 2019

Uh oh!

kegilbert commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kegilbert commented Mar 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theotherjimmy commented Mar 21, 2019

Uh oh!

0xc0170 commented Mar 22, 2019

Uh oh!

adbridge commented Mar 22, 2019

Uh oh!

kegilbert commented Mar 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Mar 22, 2019

Uh oh!

mbed-ci commented Mar 22, 2019

Test run: FAILED

Uh oh!

adbridge commented Mar 22, 2019

Uh oh!

adbridge commented Mar 22, 2019

Uh oh!

kegilbert commented Mar 22, 2019

Uh oh!

bridadan commented Mar 22, 2019

Uh oh!

cmonr commented Mar 26, 2019

Uh oh!

mbed-ci commented Mar 26, 2019

Test run: SUCCESS

Uh oh!

Uh oh!

kegilbert commented Mar 17, 2019 •

edited

Loading

kegilbert commented Mar 19, 2019 •

edited

Loading

kegilbert commented Mar 21, 2019 •

edited

Loading

kegilbert commented Mar 22, 2019 •

edited

Loading