Skip to content

Fix the removal of Mbed-added core flags in uvision exporter #10199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2019
Merged

Fix the removal of Mbed-added core flags in uvision exporter #10199

merged 1 commit into from
Mar 23, 2019

Conversation

bridadan
Copy link
Contributor

Description

Fixes the exporter CI issue that started cropping up on recent PRs (#10193, #10131).

The extra flags that we add to the core name in Mbed were not being stripped correctly. This caused the LPC55S69_NS target to not build in Uvision.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@bridadan bridadan requested a review from theotherjimmy March 22, 2019 19:06
@bridadan bridadan mentioned this pull request Mar 22, 2019
Merged
1 task
NirSonnenschein
NirSonnenschein approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@NirSonnenschein NirSonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

theotherjimmy
theotherjimmy approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Jira ticket to make this (and the one in tools/export/cmsis/__init__.py) not such a kludge?

@adbridge
Copy link
Contributor

ci started

@NirSonnenschein
Copy link
Contributor

restarted exporter to see if failure was sporadic:
23:14:20 23:14:20 [LPC55S69_NS:uvision6] Error: hudson.AbortException: script returned exit code 2
license issue?
there is also : C:\Users\ADMINI~1\AppData\Local\Temp\p544-3: Error: L6366E: ./mbed-os/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/device/TOOLCHAIN_ARMC6/lib_power.ar(fsl_power_lib.o) attributes are not compatible with the provided attributes .
@bridadan , please take a look when you can

@mbed-ci
Copy link

mbed-ci commented Mar 22, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@bridadan bridadan mentioned this pull request Mar 23, 2019
Closed
@ARMmbed ARMmbed deleted a comment from 0xc0170 Mar 23, 2019
@ARMmbed ARMmbed deleted a comment from 0xc0170 Mar 23, 2019
@bridadan bridadan force-pushed the fix_cores_in_uvision branch from 97892aa to f56bf8f Compare March 23, 2019 20:39
@adbridge
Copy link
Contributor

ci restarted

@mbed-ci
Copy link

mbed-ci commented Mar 23, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit 4e514ae into ARMmbed:master Mar 23, 2019
@cmonr cmonr removed the needs: CI label Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bridadan @adbridge @NirSonnenschein @mbed-ci @theotherjimmy @cmonr