Skip to content

Disable exporters for LPC55S69 targets #10201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Disable exporters for LPC55S69 targets #10201

wants to merge 1 commit into from

Conversation

bridadan
Copy link
Contributor

Description

There seem to be further issues with uvision using ARMC6 and the LPC55S69_NS target. Disabling this target for now to unblock the rest of the PRs.

FYI @ARMmbed/mbed-os-maintainers

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested a review from a team March 22, 2019 22:00
@ciarmcom
Copy link
Member

@bridadan, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@NirSonnenschein
Copy link
Contributor

CI started pending review

orenc17
orenc17 suggested changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@orenc17 orenc17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add sectors like the Cypress boards, just to not break working with bootloader totally

@mbed-ci
Copy link

mbed-ci commented Mar 23, 2019

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@NirSonnenschein
Copy link
Contributor

failure in ecporters looks like armc6 license issue - restarted exporters

@NirSonnenschein
Copy link
Contributor

@bridadan CI has passed with the workaround, please look at the requested changes.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 23, 2019

@orenc17 Are you able to help with this one if this is not updated within later today?

@bridadan
Copy link
Contributor Author

@orenc17 yeah I wasn't thrilled about making this change for that reason. However I don't believe this is an issue of sectors. It fails to link correctly. Nir posted the failure here: #10199 (comment)

orenc17
orenc17 reviewed Mar 23, 2019
View reviewed changes
targets/targets.json
@@ -2052,7 +2052,6 @@
"LPC"
],
"detect_code": ["0236"],
"device_name": "LPC55S69JBD100",
"release_versions": ["5"]
Copy link
Contributor

@orenc17 orenc17 Mar 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"release_versions": ["5"]
"sectors": [[196608, 512]],
"release_versions": ["5"]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm unable to move the suggestion to the _NS target...please do not commit this in the base target

@orenc17
Copy link
Contributor

orenc17 commented Mar 23, 2019

regardless of the issue in #10199 for bootloader to work you need sectors information (form CPM or targets.json)

@bridadan
Copy link
Contributor Author

Oh @orenc17 I see what you mean, sorry brain moving slow this morning. Yeah that would be a good alternative.

@bridadan
Copy link
Contributor Author

FYI @ARMmbed/mbed-os-maintainers ideally we close this PR in favor of #10199.

@bridadan
Copy link
Contributor Author

Closing this since #10199 came in.

@bridadan bridadan closed this Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenc17 orenc17 orenc17 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bridadan @ciarmcom @NirSonnenschein @mbed-ci @0xc0170 @orenc17 @adbridge