Skip to content

Cellular: fix astyle for files that already in master #10140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Mar 18, 2019

Description

Fix astyle for files that are already in master. When running astyle for branch before making a pull request, these files always pop. So making separate pr for fixing astyle for these files.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team March 18, 2019 12:00
@ciarmcom
Copy link
Member

@jarvte, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 18, 2019

Question, how these files got in ?

@jarvte
Copy link
Contributor Author

jarvte commented Mar 18, 2019

Question, how these files got in ?

That's what we were also wondering.

Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cmonr
Copy link
Contributor

cmonr commented Mar 19, 2019

@jarvte Out of curiosity, what was the local command that you used to run astyle? Also, what do you get when you run astyle --version?

Checked the history and PRs that touched these files, and they appear to be fine, so now I'm really curious as well.

@cmonr
Copy link
Contributor

cmonr commented Mar 19, 2019

Will mull over this a bit more, but we can get this PR going.

There might be something a bit more subtle going on, but it's not critical since astyle issues can be fixed without too much trouble.

@cmonr
Copy link
Contributor

cmonr commented Mar 19, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 19, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@jarvte
Copy link
Contributor Author

jarvte commented Mar 19, 2019

@cmonr astyle version: Artistic Style Version 3.1
I run these in linux and in mbed-os root:

astyle -n --options=.astylerc --recursive features/cellular/*.cpp
astyle -n --options=.astylerc --recursive features/cellular/*.c
astyle -n --options=.astylerc --recursive features/cellular/*.h

@cmonr
Copy link
Contributor

cmonr commented Mar 19, 2019

Well, I've managed to reproduce the problem.

For some reason features/cellular/framework/targets is getting parsed into the exclude list. Will submit another PR to fix things, along with whatever else may be missing.

@cmonr
Copy link
Contributor

cmonr commented Mar 19, 2019

Fix will be coming in: #10166

@0xc0170 0xc0170 merged commit 23cd1aa into ARMmbed:master Mar 20, 2019
@cmonr cmonr mentioned this pull request Mar 26, 2019
@jarvte jarvte deleted the astyle_fixes branch March 29, 2019 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants