-
Notifications
You must be signed in to change notification settings - Fork 3k
Cellular: fix astyle for files that already in master #10140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jarvte, thank you for your changes. |
Question, how these files got in ? |
That's what we were also wondering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@jarvte Out of curiosity, what was the local command that you used to run astyle? Also, what do you get when you run Checked the history and PRs that touched these files, and they appear to be fine, so now I'm really curious as well. |
Will mull over this a bit more, but we can get this PR going. There might be something a bit more subtle going on, but it's not critical since astyle issues can be fixed without too much trouble. |
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
@cmonr astyle version: Artistic Style Version 3.1
|
Well, I've managed to reproduce the problem. For some reason |
Fix will be coming in: #10166 |
Description
Fix astyle for files that are already in master. When running astyle for branch before making a pull request, these files always pop. So making separate pr for fixing astyle for these files.
Pull request type
Reviewers
Release Notes