-
Notifications
You must be signed in to change notification settings - Fork 3k
Travis CI: Tweak astyle to not over-exclude files #10166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The follow files will stop being ignored:
|
Locally ran the followign command to fix the remaining repo issues.
|
This forces directory searching to not over-exclude files. Also sorted the list, because it's nice.
Rebased. |
CI started |
0xc0170
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one
Test run: FAILEDSummary: 1 of 13 test jobs failed Failed test jobs:
|
CI restarted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem was originally reported in #10140.
It was found that the astyle job was skipping
features/cellular/framework/targets
.Further investigation found that when astyle ignores a directory, it does so by string matching, which means that ignoring
target
also ignores*/*/*/target*
...Appending './' to the astyleignore file allows the Travis CI job to not overly-exclude files.
Also, decided to sort the list.
Pull request type
Reviewers
Release Notes