Skip to content

Collect excluded libraries into ignored_dirs #10173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2019
Merged

Collect excluded libraries into ignored_dirs #10173

merged 2 commits into from
Mar 20, 2019

Conversation

theotherjimmy
Copy link
Contributor

Description

A few exporters use the resources ignored_dirs member to build a list
of directories to ignore when they scan the project for sources.

The requires section of mbed_app.json may filter a project to
include a specific set of libraries that it defines. However, this does
not update the resources.ignored_dirs member, and projects using
requires do not build when exported to gnuarmeclipse.

This PR tests this bug and corrects it.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@theotherjimmy theotherjimmy mentioned this pull request Mar 20, 2019
Merged
@0xc0170 0xc0170 requested a review from a team March 20, 2019 14:07
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 20, 2019

Set to rc4 as #10131 is also (fix needed there)

@0xc0170 0xc0170 requested a review from adbridge March 20, 2019 14:19
bridadan
bridadan approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

bulislaw
bulislaw approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍩for the test!

@theotherjimmy
Copy link
Contributor Author

@bulislaw I'm taking you up on that 🍩 😁

@cmonr
Copy link
Contributor

cmonr commented Mar 20, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 20, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 2192a87 into ARMmbed:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@bridadan bridadan bridadan approved these changes

@adbridge adbridge Awaiting requested review from adbridge

Assignees
No one assigned
Labels
release-version: 5.12.0-rc4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@theotherjimmy @0xc0170 @cmonr @mbed-ci @bulislaw @bridadan