Skip to content

Set RX1 frequency in config for logging #10202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Set RX1 frequency in config for logging #10202

wants to merge 1 commit into from

Conversation

johanstokking
Copy link
Contributor

Description

The logged frequency of the open RX1 slot is wrong at this line; https://github.com/ARMmbed/mbed-os/blob/master/features/lorawan/lorastack/mac/LoRaMac.cpp#L910

This is because the channel is filled out, but not the frequency. Only rx_config() should know the frequency (as it knows the frequency plan and RX1 DR offsets), so this change sets the frequency in there, so it gets logged correctly.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@hasnainvirk @janjongboom

Release Notes

@ciarmcom ciarmcom requested review from hasnainvirk, janjongboom and a team March 23, 2019 18:00
@ciarmcom
Copy link
Member

@johanstokking, thank you for your changes.
@janjongboom @hasnainvirk @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@hasnainvirk
Copy link
Contributor

@johanstokking I like this. I had already spotted that while doing a related task. #10214 This PR is taking care of what you need. Would that suit your needs ?

@johanstokking
Copy link
Contributor Author

Thanks @hasnainvirk, indeed #10214 already covers this.

@johanstokking johanstokking deleted the fix/log-rx1-frequency branch March 25, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants