LoRaWAN: Adding TOA and Channel info in RX metadata #10214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasnainvirk
changed the title
|
@hasnainvirk, thank you for your changes. |
cmonr
approved these changes
Mar 26, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 1 test jobs failed Failed test jobs:
|
AnttiKauppila
approved these changes
Mar 27, 2019
|
@cmonr Added function is for internal use only, so public API is untouched |
added 2 commits
March 27, 2019 10:23
We provide now downlink channel frequency and time on air for the received frame in the RX metadata. Previously the channel information in both TX and RX metada contained the index number of the channel. That information wasn't very useful except the index numbers of default channels. To make more sense of the meta data, we now store the channel frequency in the channel parameter rather than the index number of the channel. RX time on air is collected from the radio driver and it is assumed that the downlink frame had 8 downlink preamble symbols (plus 4.25 of the preambles added by the chip) for LoRa modulation. This commit also include a bit of tidying of RX frequency storage in rx configuration parameters storage. Previously we were missing filling in the RX1 frequency correctly.
The change had an impact on unittests and we needed to adjust the test cases a little to accomodate the change.
hasnainvirk
force-pushed
the
rx_metadata_toa
branch
from
c4facaf to
cd3a032
Compare
|
@AnttiKauppila @cmonr Unit tests are patched. |
|
@hasnainvirk is this ready for re-review ? |
|
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
|
@adbridge It's already reviewed. Ready for merge. |
cmonr
pushed a commit
to cmonr/mbed-os
that referenced
this pull request
Mar 28, 2019
LoRaWAN: Adding TOA and Channel info in RX metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We provide now downlink channel frequency and time on air for the
received frame in the RX metadata.
Previously the channel information in both TX and RX metada contained
the index number of the channel. That information wasn't very useful
except the index numbers of default channels. To make more sense of the
meta data, we now store the channel frequency in the channel parameter
rather than the index number of the channel.
RX time on air is collected from the radio driver and it is assumed that
the downlink frame had 8 downlink preamble symbols (plus 4.25 of the
preambles added by the chip) for LoRa modulation.
This commit also include a bit of tidying of RX frequency storage in rx
configuration parameters storage. Previously we were missing filling in
the RX1 frequency correctly.
Pull request type
Reviewers
@AnttiKauppila @kjbracey-arm @cmonr
Release Notes