-
Notifications
You must be signed in to change notification settings - Fork 3k
LPC55S69: Update Flash driver to set clock frequency #10246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPC55S69: Update Flash driver to set clock frequency #10246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just discard the binary change
@orenc17 Why is the binary change not needed? |
It has been agreed that binary updates will occur only on releases The CI is already compiling the secure binaries for each PR |
Making sure I understand then (completely possible I missed this), is there no guarantee that binaries on master are up to date? CC @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-psa? |
@orenc17 . If the binary is not updated then developers working on the master branch will not get this change, am I understanding this correctly? |
@orenc17 . If the binary is not updated then developers working on the master branch will not get this change, am I understanding this correctly? |
@alzix can update on this better |
There are prebuilt secure image binaries committed to mbed-os master, which require manual rebuild and commit. |
note that when running CI, the CI will build updated secure images prior to testing (but these images are not pushed into master). This means that any developer developing on a device that requires secure images must build these images before running as a the default ones provided as part of the OS tree are usually out of date (they will get the change if they rebuild the secure image). This approach is not the most friendly as Alex said above but it does prevent issues with changes being overrun when edited by multiple PRs at once(secure images are non-mergable). before creating a release the secure images will be updated, so that at least official releases should always have updated binaries, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmahadevan108 tfm.bin should be removed as requested above
This is to ensure the flash access time is set correctly Signed-off-by: Mahesh Mahadevan <[email protected]>
0871214
to
1b9531d
Compare
PR updated to remove binary |
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
Description
This is to ensure the flash access time is set correctly
Pull request type