Skip to content

LPC55S69: Update Flash driver to set clock frequency #10246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

mmahadevan108
Copy link
Contributor

Description

This is to ensure the flash access time is set correctly

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@mmahadevan108
Copy link
Contributor Author

cc @orenc17 @mikisch81 @0xc0170

Copy link
Contributor

@orenc17 orenc17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just discard the binary change

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

@orenc17 Why is the binary change not needed?

@cmonr cmonr requested review from cmonr and mikisch81 March 27, 2019 21:04
@orenc17
Copy link
Contributor

orenc17 commented Mar 27, 2019

It has been agreed that binary updates will occur only on releases

The CI is already compiling the secure binaries for each PR

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

Making sure I understand then (completely possible I missed this), is there no guarantee that binaries on master are up to date?

CC @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-psa?

@mmahadevan108
Copy link
Contributor Author

@orenc17 . If the binary is not updated then developers working on the master branch will not get this change, am I understanding this correctly?

@cmonr cmonr requested a review from bulislaw March 28, 2019 18:47
@mmahadevan108
Copy link
Contributor Author

@orenc17 . If the binary is not updated then developers working on the master branch will not get this change, am I understanding this correctly?

@orenc17
Copy link
Contributor

orenc17 commented Mar 29, 2019

@alzix can update on this better

@alzix
Copy link
Contributor

alzix commented Mar 31, 2019

There are prebuilt secure image binaries committed to mbed-os master, which require manual rebuild and commit.
I'm not fond of this approach, but it is here for providing backward compatibility (in term of build instructions) for application developers working with default secure image.
This technique has its own drawbacks, request for rebuild&commit secure images upon any change is one of them.
We will work to provide better user experience in the upcoming releases.

@NirSonnenschein
Copy link
Contributor

note that when running CI, the CI will build updated secure images prior to testing (but these images are not pushed into master). This means that any developer developing on a device that requires secure images must build these images before running as a the default ones provided as part of the OS tree are usually out of date (they will get the change if they rebuild the secure image). This approach is not the most friendly as Alex said above but it does prevent issues with changes being overrun when edited by multiple PRs at once(secure images are non-mergable). before creating a release the secure images will be updated, so that at least official releases should always have updated binaries,

0xc0170
0xc0170 previously requested changes Apr 1, 2019
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmahadevan108 tfm.bin should be removed as requested above

This is to ensure the flash access time is set correctly

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108 mmahadevan108 force-pushed the Fix_LPC55S69_Flash_ClockSpeed branch from 0871214 to 1b9531d Compare April 1, 2019 17:10
@mmahadevan108
Copy link
Contributor Author

PR updated to remove binary

@cmonr cmonr dismissed 0xc0170’s stale review April 1, 2019 22:18

Binary removed.

@cmonr
Copy link
Contributor

cmonr commented Apr 1, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 2, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 4950178 into ARMmbed:master Apr 2, 2019
@mmahadevan108 mmahadevan108 deleted the Fix_LPC55S69_Flash_ClockSpeed branch April 5, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants