Skip to content

FUTURE_SEQUANA: Fixed LP ticker for M0 core #10291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2019
Merged

FUTURE_SEQUANA: Fixed LP ticker for M0 core #10291

merged 2 commits into from
Apr 3, 2019

Conversation

lrusinowicz
Copy link
Contributor

@lrusinowicz lrusinowicz commented Apr 2, 2019 •
edited
Loading

Description

Fixed interrupt vector settings on M0 core - this was likely merge error (on my side) when submitting #9678. Wrong vector settings prevented LP_TICKER from working, resulting in deep sleep tests failing.
Also regenerated PSA M0 image to fix SEQUANA PSA deep sleep tests (fixes issue #9095).

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@0xc0170 0xc0170 requested a review from orenc17 April 2, 2019 08:54
@orenc17
Copy link
Contributor

orenc17 commented Apr 2, 2019

i'll need to verify this later today.. but the changes look fine
just drop the hex file

@lrusinowicz
Copy link
Contributor Author

@orenc17
So the old M0 image should stay? With the old image #9095 won't be fixed.

@orenc17
Copy link
Contributor

orenc17 commented Apr 2, 2019

please refer to #10246

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 2, 2019

please refer to #10246

@orenc17 Is this documented anywhere ? we should rather reference documentation

@lrusinowicz
FUTURE_SEQUANA: Fixed LP ticker for M0 core
f0e0e9f 
Fixed interrupt vector settings on M0 core. Wrong vector settings prevented
LP_TICKER from working, resulting in deep sleep tests failing on M0
or PSA variant.
@lrusinowicz lrusinowicz force-pushed the sequana_psa_deepsleep branch from 2f71bfb to f0e0e9f Compare April 2, 2019 11:33
@cmonr
Copy link
Contributor

cmonr commented Apr 2, 2019

this was likely merge error (on my side) when submitting #9678.

CC @ARMmbed/mbed-os-maintainers Not an issue now, but it's interesting that this can happen.

@cmonr
Copy link
Contributor

cmonr commented Apr 2, 2019

@orenc17 If you'd like to OK the PR.

@cmonr
Copy link
Contributor

cmonr commented Apr 2, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 2, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

orenc17
orenc17 approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@orenc17 orenc17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.. tested on my board psa tests pass now

@lrusinowicz
Copy link
Contributor Author

this was likely merge error (on my side) when submitting #9678.

CC @ARMmbed/mbed-os-maintainers Not an issue now, but it's interesting that this can happen.

I've ment my internal merge when cleaning up the branch for submission. I had tested those changes to work, but what l had submitted didn't.

@0xc0170 0xc0170 merged commit 1d26dbb into ARMmbed:master Apr 3, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 5, 2019

@lrusinowicz Not certain what has happened but commit 73f486d is empty ? Causing our release script to fail, will patch manually

@lrusinowicz lrusinowicz mentioned this pull request Apr 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@orenc17 orenc17 orenc17 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lrusinowicz @orenc17 @0xc0170 @cmonr @mbed-ci @adbridge