Skip to content

FUTURE_SEQUANA_PSA: fixed deep sleep mode #9678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2019
Merged

FUTURE_SEQUANA_PSA: fixed deep sleep mode #9678

merged 1 commit into from
Feb 13, 2019

Conversation

lrusinowicz
Copy link
Contributor

@lrusinowicz lrusinowicz commented Feb 12, 2019 •
edited by 0xc0170
Loading

Description

Enabled tickless mode for Sequana PSA M0 core code to allow it to enter
deep sleep mode. This fixes issue #9094 where tests were failing due to
M0 core not entering deep sleep mode, blocking the whole chip.
Fixed incorrect resource management on M0 core, which crashed tickless
mode.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@orenc17

@lrusinowicz
FUTURE_SEQUANA_PSA: fixed deep sleep mode
92b019f 
Enabled tickless mode for Sequana PSA M0 core code to allow it to enter
deep sleep mode. This fixes issue ARMmbed#9094 where tests were failing due to
M0 core not entering deep sleep mode, blocking the whole chip.
Fixed incorrect resource management on M0 core, which crashed tickless
mode.
@lrusinowicz
Copy link
Contributor Author

I've just noticed a conflict with #9666, so I will need to rebase it after #966 is merged in.

@ciarmcom
Copy link
Member

@lrusinowicz, thank you for your changes.
@orenc17 @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from orenc17 and a team February 12, 2019 10:00
@orenc17
Copy link
Contributor

orenc17 commented Feb 12, 2019

@lrusinowicz if #9666 is merged before please regenerate the binaries again

@lrusinowicz
Copy link
Contributor Author

@lrusinowicz if #9666 is merged before please regenerate the binaries again

@orenc17 Do you mean #9633? Because #9666 does not have a 'merged' status.

@orenc17
Copy link
Contributor

orenc17 commented Feb 12, 2019

@lrusinowicz if #9666 is merged before please regenerate the binaries again

@orenc17 Do you mean #9633? Because #9666 does not have a 'merged' status.

@lrusinowicz both
#9633 is the feature
#9666 is the actual implementation on FUTURE_SEQUANA_PSA

@ciarmcom ciarmcom requested a review from orenc17 February 12, 2019 12:00
@ciarmcom
Copy link
Member

@lrusinowicz, thank you for your changes.
@orenc17 @ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019

Hmm, there was some back and forth, so making sure I understand.

@orenc17
Between this PR and #9666, once either is merged, the other will need to rebase and include an updated binary?

cmonr
cmonr reviewed Feb 12, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will reapprove once question about magic number is addressed.

targets/TARGET_Cypress/TARGET_PSOC6_FUTURE/TARGET_FUTURE_SEQUANA_M0_PSA/spm_init_api.c
ipc_intr_Config.cm0pSrc = (cy_en_intr_t)cpuss_interrupts_ipc_0_IRQn + SPM_IPC_NOTIFY_CM0P_INTR; // Must match the interrupt we trigger using NOTIFY on CM4
ipc_intr_Config.intrPriority = 1;
if (cy_m0_nvic_reserve_channel(CY_M0_CORE_IRQ_CHANNEL_PSA_MAILBOX, CY_PSA_MAILBOX_IRQN_ID) == (IRQn_Type)(-1)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 is oddly specific. What does the magic number map to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It refers to targets/TARGET_Cypress/TARGET_PSOC6_FUTURE/psoc6_utils.h:

 *
 * \param channel IRQn_Type     Channel to be reserved.
 * \param allocation_id uint32_t    Identifier.
 * \return  IRQ channel allocated or (-1) if no free channel is available.
 *
 */
IRQn_Type cy_m0_nvic_reserve_channel(IRQn_Type channel, uint32_t allocation_id);

Yeah, it's sloppy. But fixing this requires a global HAL implementation change, that I would rather prepare as a separate PR.

@orenc17
Copy link
Contributor

orenc17 commented Feb 12, 2019 •
edited by cmonr
Loading

Hmm, there was some back and forth, so making sure I understand.

@orenc17
Between this PR and #9666, once either is merged, the other will need to rebase and include an updated binary?

@cmonr, correct

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019

CI started

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2019

Making a note here to prefer this PR over #9666 if it comes down to it.

@cmonr cmonr mentioned this pull request Feb 12, 2019
Merged
@mbed-ci
Copy link

mbed-ci commented Feb 13, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit ba7aa88 into ARMmbed:master Feb 13, 2019
@cmonr
Copy link
Contributor

cmonr commented Feb 21, 2019

PSA PR. Bumped to 5.12

@lrusinowicz lrusinowicz mentioned this pull request Mar 15, 2019
Closed
@lrusinowicz lrusinowicz mentioned this pull request Apr 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr left review comments

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

@orenc17 orenc17 orenc17 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lrusinowicz @ciarmcom @orenc17 @cmonr @mbed-ci @NirSonnenschein @0xc0170