PinNames.h: #10460
Closed
PinNames.h: #10460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removing definition of Status LED. - Redefining SPI and I2C pin names using Arduino pins names. system_clock.c: - Set AWAKE signal high to ensure VIO through SDP and Arduino connectors to daughter boards.
|
SDP_K1_GCC_ARM_test.log Attaching test files. |
bulislaw
suggested changes
Apr 24, 2019
There was a problem hiding this comment.
Hi there, thanks for your contribution. Couple of points:
- Please remove dead code (or at least don't introduce any new dead code)
- Split the changes into two commits: pin names and system clock changes
- Provide meaningful titles for commits (including the affected platform)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvements made to board support package of SDP-K1.
PinNames.h:
system_clock.c:
Pull request type