Skip to content

SDP-K1: Updates to target code #10471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 2, 2019
Merged

SDP-K1: Updates to target code #10471

merged 4 commits into from
May 2, 2019

Conversation

malavikasajikumar
Copy link
Contributor

Description

Improvements made to PinNames.h of SDP-K1 board.
AWAKE signal turned on at system init for SDP-K1 board.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@bulislaw

Release Notes

@malavikasajikumar malavikasajikumar mentioned this pull request Apr 24, 2019
Closed
@ciarmcom ciarmcom requested review from bulislaw and a team April 25, 2019 11:07
@ciarmcom
Copy link
Member

@malavikasajikumar, thank you for your changes.
@bulislaw @ARMmbed/mbed-os-maintainers please review.

@bulislaw bulislaw changed the title Master SDP-K1: Updates to target code Apr 25, 2019
@bulislaw
Copy link
Member

Hi @malavikasajikumar thanks for that, one more thing could you remove the first two commits? First one introduces changes and second is reverting them

PinNames.h: d9de36a79723872a7ad386cc058722d89070443d
Revert "PinNames.h:" ffe74404f99f2d18499c6e32f0f1cb529e0bb937

You can do it easily using git rebase -i a3157e2 and removing two lines that list commits mentioned above, then you just force push it to your fork and the PR will be automatically refreshed.

@malavikasajikumar
Improvements made to PinNames.h of SDP-K1 board.
869e48d 
PinNames.h:
- Removing definition of Status LED.
- Redefining SPI and I2C pin names using Arduino pins names.
@malavikasajikumar
AWAKE signal turned on at system init for SDP-K1 board.
f11f63d 
- Setting AWAKE signal high in the SystemInit() to ensure VIO supply to daughter boards through SDP and Arduino connectors.
@malavikasajikumar
Copy link
Contributor Author

Hi @malavikasajikumar thanks for that, one more thing could you remove the first two commits? First one introduces changes and second is reverting them

PinNames.h: d9de36a79723872a7ad386cc058722d89070443d
Revert "PinNames.h:" ffe74404f99f2d18499c6e32f0f1cb529e0bb937

You can do it easily using git rebase -i a3157e2 and removing two lines that list commits mentioned above, then you just force push it to your fork and the PR will be automatically refreshed.

@bulislaw Thanks for the suggestion. Done. Let me know if any other changes are needed.

0xc0170
0xc0170 requested changes Apr 29, 2019
View reviewed changes
targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F469xI/TARGET_SDP_K1/PinNames.h Outdated
LED2 = PK_6, // Orange LED
LED3 = PK_5, // Green LED
LED_RED = LED1,
LED_ORANGE = LED2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix alignment in this file (LED_ORANGE aligned with LED_RED and others for instance)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @0xc0170.
e0faeb2

bulislaw
bulislaw approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xc0170
0xc0170 requested changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just year change is not correct. As soon as updated, will go into CI

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F469xI/TARGET_SDP_K1/system_clock.c Outdated
@@ -1,7 +1,7 @@
/* mbed Microcontroller Library
* Copyright (c) 2006-2019 ARM Limited
* Copyright (c) 2006-2017 ARM Limited
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2019 as this one is being edited this year

@0xc0170
Copy link
Contributor

0xc0170 commented May 2, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented May 2, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@alekla01
Copy link
Contributor

alekla01 commented May 2, 2019

restarted jenkins-ci

@0xc0170
Copy link
Contributor

0xc0170 commented May 2, 2019

Ci restarted again

@mbed-ci
Copy link

mbed-ci commented May 2, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit 87711a9 into ARMmbed:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@malavikasajikumar @ciarmcom @bulislaw @0xc0170 @mbed-ci @alekla01