-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix #10589 for STM32F4 #10595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #10589 for STM32F4 #10595
Conversation
@embeddedteam103, thank you for your changes. |
@adbridge Is that |
@SeppoTakalo The review bot is only as good as the data fed to it. The current mappings live here https://github.com/ARMmbed/mbed-os-ci-scripts/blob/master/reviewers/config/reviewers.json. Please feel free to raise a PR to add/correct anything that is missing/wrong or needs updating. Thanks. |
@adbridge Don't see my team in that line https://github.com/ARMmbed/mbed-os-ci-scripts/blob/master/reviewers/config/reviewers.json#L109 Why would it trigger so many reviewers? |
@SeppoTakalo In this case i suspect it is because of the merge commit added to this PR which will thus have touched many files and the internal Git API is seeing that. @embeddedteam103 Please do not submit merge commits to PRs. Please instead rebase and repush. |
Please wait from @ARMmbed/team-st-mcd confirmation before merging this. |
@embeddedteam103 I believe there is one commit that should not be here (can you please rebase to clean up the history - the fix is just one commit?) Explains why so many reviewers, I removed them. |
@ARMmbed/team-st-mcd Please review |
Any update? I'll run CI meanwhile |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Set to needs: work as feedback in 10589 was provided |
Hi |
Closing, 10804 going ahead |
Description
Resolve #10589 for STM32F4 targets.
Pull request type
Reviewers
Release Notes