Update cube h7 to 1.4.0 #10631
Merged
Update cube h7 to 1.4.0 #10631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromecoutant
approved these changes
May 22, 2019
|
Note that this STM32H7 driver version is introducing Dual Core targets, including H747 |
|
@VVESTM, thank you for your changes. |
0xc0170
reviewed
May 22, 2019
| @@ -82,7 +82,7 @@ static const uint16_t USART_PRESCALER_TAB[] = | |||
| #endif /*USE_FULL_LL_DRIVER*/ | |||
|
|
|||
| /* Exported types ------------------------------------------------------------*/ | |||
| #if defined(USE_FULL_LL_DRIVER) | |||
| #if 1 //mbed | |||
There was a problem hiding this comment.
we dont rather define the macro as 1 instead of rewriting the driver files?
There was a problem hiding this comment.
You're right. I have done like this because it was already the case before...
I check how to clean this part.
|
Let us know once updated, we can start CI. |
Keep #define USE_FULL_LL_DRIVER and define this switch in target.json Signed-off-by: Vincent Veron <[email protected]>
|
Here is a new version removing the previous #if 1... |
0xc0170
approved these changes
May 23, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update of the cube H7 HAL and LL. This is coming from st.com website : https://www.st.com/en/embedded-software/stm32cubeh7.html
Used version is 1.4.0
Pull request type
Reviewers
@jeromecoutant