Skip to content

Export wait_ns to be overridable #10683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2019
Merged

Export wait_ns to be overridable #10683

merged 1 commit into from
Jun 3, 2019

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented May 28, 2019

Description

This PR is replacement for #10632. Some targets may not provide zero-wait-state flash performance. Export wait_ns to be overridable for targets to provide more accurate implementation like locating delay_loop_code in SRAM.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kjbracey-arm

@ccli8
Export wait_ns to be overridable
e9885fe 
Some targets may not provide zero-wait-state flash performance. Export this function
to be overridable for targets to provide more accurate implementation like locating
'delay_loop_code' in SRAM.
@ccli8 ccli8 mentioned this pull request May 28, 2019
Closed
@kjbracey
Copy link
Contributor

kjbracey commented May 28, 2019 •
edited
Loading

Still would like to see M2351's cache enabled so this wasn't necessary (for it) though.

@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019

I've just noticed nightly failures for this:

| NUMAKER_PFM_M487-ARMC6 | NUMAKER_PFM_M487 | tests-mbed_platform-wait_ns                                                  | FAIL   | 41.21              | default     |

This PR should fix it, shouldn't it?

@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019

Wait, it only provides a hook, not the real fix.

@0xc0170 0xc0170 mentioned this pull request May 31, 2019
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented May 31, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit a93542b into ARMmbed:master Jun 3, 2019
@ccli8 ccli8 mentioned this pull request Jun 3, 2019
Merged
@kjbracey kjbracey mentioned this pull request Jun 24, 2019
Closed
@ccli8 ccli8 deleted the nuvoton_wait-ns_weak branch July 11, 2019 09:01
@ccli8 ccli8 mentioned this pull request Jul 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjbracey kjbracey kjbracey approved these changes

Assignees
No one assigned
Labels
release-version: 5.14.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccli8 @kjbracey @0xc0170 @mbed-ci