Nuvoton: Modify wait ns(...) to provide more accurate implementation #11019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add missing header file for mbed_mpu_manager_lock_ram_execution()/
mbed_mpu_manager_unlock_ram_execution() to avoid compile warning.
2. Locate delay_loop_code() on 16-byte boundary (sync to common version).
3. Optimize delay_loop macro (sync to common version).
NANO100 series doesn't support cache and so cannot provide zero-wait state flash performance.
NUC472 series doesn't support cache but supports branch buffer. But it still cannot provide zero-wait state flash performance.
kjbracey
approved these changes
Jul 11, 2019
artokin
approved these changes
Jul 15, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
@SeppoTakalo One thing to note. This PR relies on #10683 which is targeted for 5.14.0. Correct the release version? |
|
Indeed, the target should have been 5.14.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies
wait_ns(...)for Nuvoton targets:wait_ns(...)to synchronize to common version.wait_ns(...)to SRAM from flash because flash code performance cannot achieve zero-wait state without cache support.Pull request type