Skip to content

Add a top level README file for USB tests #10688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2019
Merged

Add a top level README file for USB tests #10688

merged 1 commit into from
Jun 19, 2019

Conversation

fkjagodzinski
Copy link
Member

Description

Add setup instructions and aggregate all the info from README files
related to USB testing.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jamesbeyond @c1728p9

Release Notes

Add a top level README file for USB tests
0ae1be0 
Add setup instructions and aggregate all the info from README files
related to USB testing.
@ciarmcom ciarmcom requested review from c1728p9, jamesbeyond and a team May 28, 2019 15:01
@ciarmcom
Copy link
Member

@fkjagodzinski, thank you for your changes.
@jamesbeyond @c1728p9 @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from AnotherButler May 31, 2019 09:02
c1728p9
c1728p9 approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@c1728p9 c1728p9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this get its own docs page as well?

@jamesbeyond
Copy link
Contributor

Should this get its own docs page as well?

Or maybe a link to the test section in usb porting page?
https://os.mbed.com/docs/mbed-os/v5.12/porting/usb-device.html

jamesbeyond
jamesbeyond approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fkjagodzinski fkjagodzinski mentioned this pull request Jun 17, 2019
Merged
@adbridge
Copy link
Contributor

CI started.

@adbridge adbridge merged commit aa9bd48 into ARMmbed:master Jun 19, 2019
@fkjagodzinski fkjagodzinski deleted the test_update-docs-usb branch June 19, 2019 11:22
@fkjagodzinski
Copy link
Member Author

Or maybe a link to the test section in usb porting page?
https://os.mbed.com/docs/mbed-os/v5.12/porting/usb-device.html

Good idea @jamesbeyond; here is the docs update: ARMmbed/mbed-os-5-docs#1096.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c1728p9 c1728p9 c1728p9 approved these changes

@adbridge adbridge adbridge approved these changes

@jamesbeyond jamesbeyond jamesbeyond approved these changes

@AnotherButler AnotherButler Awaiting requested review from AnotherButler

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fkjagodzinski @ciarmcom @jamesbeyond @adbridge @c1728p9 @0xc0170