-
Notifications
You must be signed in to change notification settings - Fork 3k
Add USB Device implementation, fix a bug for serial #10712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ChazJin, thank you for your changes. |
@maciejbocianski - Can you please review? @ChazJin Can you please rebase? Sorry for the delay to get the review |
How was this tested ? |
@0xc0170 We have written some test codes such as virtual USB serial port and USB mouse and verified on GD32_F450ZI board. Once these files are merged, we will upload these routines as example programs. |
Hi @0xc0170, Here is a simple example of virtual USB serial port, which can be compiled and then downloaded directly to the GD32_F450ZI board to observe the results. Do we have to do some other tests?
@maciejbocianski Could you please help to review when you have some time? Thanks a lot. |
Please provide results from all USB tests. To runt the test use following command: Available USB test:
There is a README file describing all corner cases. Mass storage test was unstable and fix was provided. Before running it please download changes provided in the following PR: #10767 |
@ChazJin Any update for this pull request? There's conflict and requests above from @maciejbocianski |
@0xc0170 I am very sorry, we found some problems during the recent USB test. Only TESTS/usb_device/serial can pass the test, and the others all fail. We're looking for reasons. |
@ChazJin This PR is still opened but has not progressed for 2 months ? I'll close this. Please reopen once updated ,we will review. |
Description
Implemented USB Device on GD32F450ZI target.
Update targets.json for adding USBDEVICE feature
Added implementation code for USB Device in usb/device/targets/TARGET_GigaDevice/...
Fix a bug for serial when stdio-buffered-serial is enabled.
Pull request type
Reviewers
@0xc0170 @Ronny-Liu I would appreciate if you could review it when you are free.
Release Notes