Skip to content

Move Seeed ARCH_MAX to TARGET_STM32F407xE MCU #10758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2019
Merged

Move Seeed ARCH_MAX to TARGET_STM32F407xE MCU #10758

merged 4 commits into from
Jun 9, 2019

Conversation

toyowata
Copy link
Contributor

@toyowata toyowata commented Jun 5, 2019

Description

This PR fix the issue here.

  • Create TARGET_STM32F407xE MCU target
  • Move ARCH_MAX under the TARGET_STM32F407xE
  • Fix flash size from 1MB to 512kB

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Test result

mbedgt: test suite report:
| target         | platform_name | test suite                                                                   | result  | elapsed_time (sec) | copy_method |
|----------------|---------------|------------------------------------------------------------------------------|---------|--------------------|-------------|
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-basic_test                        | OK      | 26.9               | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-basic_test_default                | OK      | 26.88              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-case_async_validate               | OK      | 28.35              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-case_control_async                | OK      | 34.93              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-case_control_repeat               | OK      | 28.85              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-case_selection                    | OK      | 26.77              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-case_setup_failure                | OK      | 27.2               | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-case_teardown_failure             | OK      | 27.51              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-control_type                      | OK      | 27.34              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-minimal_async_scheduler           | OK      | 27.69              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-minimal_scheduler                 | OK      | 28.21              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-test_assertion_failure_test_setup | OK      | 26.38              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-test_setup_case_selection_failure | OK      | 26.71              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-test_setup_failure                | OK      | 26.43              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-frameworks-utest-tests-unit_tests-test_skip                         | OK      | 26.87              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-storage-nvstore-tests-nvstore-functionality                         | OK      | 51.03              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-storage-tests-blockdevice-buffered_block_device                     | OK      | 26.79              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-storage-tests-blockdevice-flashsim_block_device                     | OK      | 26.58              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-storage-tests-blockdevice-general_block_device                      | OK      | 26.17              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-storage-tests-blockdevice-heap_block_device                         | OK      | 28.66              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-storage-tests-blockdevice-mbr_block_device                          | OK      | 27.79              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-storage-tests-blockdevice-util_block_device                         | OK      | 27.19              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-storage-tests-kvstore-static_tests                                  | OK      | 40.78              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | features-storage-tests-kvstore-tdbstore_whitebox                             | OK      | 27.25              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-events-queue                                                           | OK      | 34.43              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-events-timing                                                          | OK      | 88.18              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-integration-basic                                                      | OK      | 24.85              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_drivers-c_strings                                                 | OK      | 28.72              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_drivers-crc                                                       | OK      | 27.51              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_drivers-dev_null                                                  | OK      | 27.87              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_drivers-echo                                                      | TIMEOUT | 112.33             | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_drivers-flashiap                                                  | OK      | 44.32              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_drivers-generic_tests                                             | OK      | 27.02              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_drivers-race_test                                                 | TIMEOUT | 111.24             | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_drivers-rtc                                                       | FAIL    | 42.13              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_drivers-sleep_lock                                                | OK      | 69.45              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_drivers-stl_features                                              | OK      | 27.58              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_drivers-ticker                                                    | OK      | 51.55              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_drivers-timeout                                                   | OK      | 65.13              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_drivers-timer                                                     | OK      | 34.33              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_drivers-timerevent                                                | OK      | 28.65              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_functional-callback                                               | OK      | 28.12              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_functional-callback_big                                           | OK      | 28.23              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_functional-callback_small                                         | OK      | 27.46              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_functional-functionpointer                                        | OK      | 26.86              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-common_tickers                                                | OK      | 29.0               | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-common_tickers_freq                                           | OK      | 124.29             | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-critical_section                                              | OK      | 26.89              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-flash                                                         | OK      | 31.27              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-gpio                                                          | OK      | 26.32              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-minimum_requirements                                          | OK      | 26.54              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-mpu                                                           | OK      | 27.42              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-pinmap                                                        | OK      | 27.06              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-rtc                                                           | FAIL    | 63.82              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-rtc_reset                                                     | OK      | 31.6               | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-rtc_time                                                      | OK      | 30.85              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-rtc_time_conv                                                 | OK      | 44.94              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-sleep                                                         | OK      | 26.49              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-sleep_manager                                                 | OK      | 26.48              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-sleep_manager_racecondition                                   | OK      | 39.43              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-stack_size_unification                                        | OK      | 26.48              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-ticker                                                        | OK      | 38.09              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-trng                                                          | OK      | 28.43              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_hal-us_ticker                                                     | OK      | 26.59              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_platform-atomic                                                   | OK      | 34.79              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_platform-circularbuffer                                           | OK      | 32.81              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_platform-critical_section                                         | OK      | 28.26              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_platform-error_handling                                           | OK      | 27.4               | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_platform-filehandle                                               | OK      | 28.25              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_platform-sharedptr                                                | OK      | 27.12              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_platform-singletonptr                                             | OK      | 26.79              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_platform-stream                                                   | OK      | 26.59              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_platform-system_reset                                             | OK      | 27.12              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_platform-transaction                                              | OK      | 27.56              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbed_platform-wait_ns                                                  | OK      | 27.51              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-mbed-attributes                                              | OK      | 28.44              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-mbed-call_before_main                                        | OK      | 25.82              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-mbed-cpp                                                     | OK      | 26.0               | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-mbed-div                                                     | OK      | 26.09              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-mbed-static_assert                                           | OK      | 26.45              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-rtos-mbed-basic                                              | OK      | 36.29              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-rtos-mbed-condition_variable                                 | OK      | 26.88              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-rtos-mbed-event_flags                                        | OK      | 29.5               | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-rtos-mbed-heap_and_stack                                     | OK      | 27.46              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-rtos-mbed-kernel_tick_count                                  | OK      | 28.99              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-rtos-mbed-mail                                               | OK      | 31.91              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-rtos-mbed-malloc                                             | OK      | 49.13              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-rtos-mbed-memorypool                                         | OK      | 33.86              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-rtos-mbed-mutex                                              | OK      | 30.97              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-rtos-mbed-queue                                              | OK      | 29.8               | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-rtos-mbed-rtostimer                                          | OK      | 28.6               | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-rtos-mbed-semaphore                                          | OK      | 31.26              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-rtos-mbed-signals                                            | OK      | 33.06              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedmicro-rtos-mbed-threads                                            | OK      | 38.42              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedtls-multi                                                          | OK      | 27.74              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-mbedtls-selftest                                                       | OK      | 28.78              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-netsocket-dns                                                          | OK      | 51.68              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-netsocket-tcp                                                          | OK      | 109.46             | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-netsocket-tls                                                          | OK      | 92.31              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-netsocket-udp                                                          | OK      | 54.18              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-network-interface                                                      | OK      | 49.55              | default     |
| ARCH_MAX-ARMC6 | ARCH_MAX      | tests-network-l3ip                                                           | OK      | 26.51              | default     |
mbedgt: test suite results: 2 FAIL / 98 OK / 2 TIMEOUT

RTC related test cases failed. I believe this is same issue here: #8196

Detail test log:
arch_max-arm.txt
arch_max-gcc_arm.txt
arch_max-iar.txt

cc @ytsuboi

@ciarmcom ciarmcom requested a review from a team June 5, 2019 07:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 5, 2019

@toyowata, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 requested changes Jun 5, 2019
View reviewed changes
targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F407xE/objects.h Outdated
@@ -0,0 +1,67 @@
/* mbed Microcontroller Library
*******************************************************************************
* Copyright (c) 2014, STMicroelectronics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add SPDX identifier for new files like this one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 Thanks. I added SPDX identifiers.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 5, 2019

Travis fails E AssertionError: Target ARCH_MAX contains invalid device_name STM32F407VE - device name not recognized

@jeromecoutant
Copy link
Collaborator

Travis fails E AssertionError: Target ARCH_MAX contains invalid device_name STM32F407VE - device name not recognized

It seems you have to:

  • set device_name value to STM32F407VETx
  • or add in tools/arm_pack_manager/legacy-names.json file: "STM32F407VE": "STM32F407VETx",

@toyowata
Copy link
Contributor Author

toyowata commented Jun 5, 2019

@0xc0170 @jeromecoutant Thanks. I fixed device_name and SPDX identifiers.

0xc0170
0xc0170 reviewed Jun 5, 2019
View reviewed changes
targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F407xE/device/system_stm32f4xx.h Outdated
*
* <h2><center>&copy; COPYRIGHT(c) 2017-2019 STMicroelectronics</center></h2>
*
* SPDX-License-Identifier: Apache-2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is BSD not Apache

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other files as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 Thanks for point this out. Fixed.

@0xc0170 0xc0170 requested a review from a team June 5, 2019 08:56
ytsuboi
ytsuboi approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@ytsuboi ytsuboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 356c4fb into ARMmbed:master Jun 9, 2019
@toyowata toyowata deleted the stm32f407xe branch June 10, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytsuboi ytsuboi ytsuboi approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@toyowata @ciarmcom @0xc0170 @jeromecoutant @mbed-ci @ytsuboi @adbridge