Skip to content

FastModel: trun off MPU for FVP_MPS2_M0P #10795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2019

Conversation

jamesbeyond
Copy link
Contributor

Description

MPU is optional on Cortex-M0plus
By default, on FVP_MPS2_M0P target not having the MPU, so the SDK was miss-configured.
Fixing the issue by turning them off.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested a review from a team June 7, 2019 19:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 7, 2019

@jamesbeyond, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 13, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 14, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 14, 2019

There's fix proposed in #10833, will restart CI after

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 15, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
  • jenkins-ci/mbed-os-ci_greentea-test

@jamesbeyond
Copy link
Contributor Author

I had checked the errors, they are not relevant. They are on Ublox Nucleo K66F targets.
these targets should not impacted by this PR. worth to restart CI again.

@adbridge
Copy link
Contributor

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jun 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@adbridge adbridge merged commit 4bd1d15 into ARMmbed:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants