Skip to content

fix IAR compile error on fastmodels #10833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2019
Merged

fix IAR compile error on fastmodels #10833

merged 1 commit into from
Jun 15, 2019

Conversation

jamesbeyond
Copy link
Contributor

Description

Fixing issue #10832 10832

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

0xc0170
0xc0170 approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally passed the failing tests before.

The double macro definition causing IAR asm to fail.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 14, 2019

CI started

This was referenced Jun 14, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@mbed-ci
Copy link

mbed-ci commented Jun 14, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 14, 2019

Needs to be restarted - test. Good news is build for IAR passed 👍

@adbridge
Copy link
Contributor

Restarted ci

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 14, 2019

@ARMmbed/mbed-os-test there're failures that appear from time to time like that flash test for AD target. Let's put that device into maintenance

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 14, 2019

The specific failing flash target is disabled, test restarted

@0xc0170 0xc0170 merged commit 9974899 into ARMmbed:master Jun 15, 2019
@0xc0170 0xc0170 mentioned this pull request Jun 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesbeyond @0xc0170 @mbed-ci @adbridge