Bring FPGA SPI tests to feature-hal-spec-spi #10816

mprse · 2019-06-12T14:03:57Z

Description

This PR provides the following changes:

brings SPI master/slave tests designed for the FPGA-Test-Shield to the spi feature branch,
enables FPGA test shield component for: K64F, K66F, NUCLEO_F429ZI (can FPGA-Test-Shield be connected to these CI boards ?),
adds limitation for supported clock modes (K64F),
adds documentation for FPGA-Test-Shield SPI tests (new HAL API)

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@jamesbeyond Can you check the test documentation?

ciarmcom · 2019-06-12T15:00:39Z

@mprse, thank you for your changes.
@jamesbeyond @ARMmbed/mbed-os-maintainers please review.

adbridge · 2019-06-20T15:30:22Z

@jamesbeyond could you review please?

mprse · 2019-06-21T09:08:48Z

Removed commit which adds FPGA test shield component for: K64F, K66F, NUCLEO_F429ZI. With this component, spi tests would be executed on CI and probably Ci boards do not have FPGA-Test-Shields connected.
To run the tests this component must be added manually.

jamesbeyond · 2019-07-03T10:29:38Z

Hi @ARMmbed/mbed-os-maintainers this PR is for workshop next week, please mark this as high importance.

jamesbeyond

The header files for the tests are required

mprse · 2019-07-03T14:08:09Z

Added test header files and mapped test functions to the defined behavior.
PR is ready for review and CI.

jamesbeyond

The header files look good

0xc0170 · 2019-07-05T07:42:58Z

In CI now

mbed-ci · 2019-07-05T08:06:14Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR

…avior. Also, update names of the test functions (basic test and fpga tests) so they are more consistent and unique.

0xc0170 · 2019-07-05T09:41:33Z

This needs to be rebased now

mprse · 2019-07-05T09:56:43Z

Rebased feature branch and this PR.

0xc0170 · 2019-07-05T09:57:22Z

In CI now

mbed-ci · 2019-07-05T10:20:59Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-ARM

0xc0170 · 2019-07-05T11:24:27Z

CI restarted

mprse · 2019-07-05T13:24:31Z

If this will pass please DO NOT MERGE I will add test restrictions as here: PR #10975

mbed-ci · 2019-07-05T14:27:28Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

mprse · 2019-07-05T14:35:46Z

@0xc0170 Added restriction for Arduino form factor only. We can start CI again and remove do not merge.

0xc0170 · 2019-07-08T07:59:43Z

CI restarted

mbed-ci · 2019-07-08T09:46:03Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR

SPI is disabled for this target on spi feature branch.

mprse · 2019-07-08T11:39:55Z

Looks like now CI is building Mbed-os for all targets and some issues have been found.
All should be fixed now.

@0xc0170 Can we try again?

0xc0170 · 2019-07-08T11:45:50Z

CI restarted

mbed-ci · 2019-07-08T16:27:02Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 5
Build artifacts

mprse · 2019-07-08T17:08:31Z

@0xc0170 Ready do go!

ciarmcom requested review from jamesbeyond and a team June 12, 2019 15:00

ciarmcom added the needs: review label Jun 12, 2019

mprse mentioned this pull request Jun 13, 2019

Bring FPGA-Test-Shield tests into Mbed-os master. #10820

Merged

0xc0170 added the release-version: feature branch label Jun 13, 2019

mprse force-pushed the bring_fpga_spi_tests branch from feb576e to 3a9b530 Compare June 21, 2019 09:06

jamesbeyond suggested changes Jul 3, 2019

View reviewed changes

jamesbeyond approved these changes Jul 4, 2019

View reviewed changes

0xc0170 approved these changes Jul 5, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Jul 5, 2019

0xc0170 approved these changes Jul 5, 2019

View reviewed changes

0xc0170 added needs: work priority: high and removed needs: CI labels Jul 5, 2019

0xc0170 force-pushed the feature-hal-spec-spi branch from d7e4b82 to a42e9b4 Compare July 5, 2019 09:13

mprse added 4 commits July 5, 2019 11:18

K64F SPI driver: add limitation for supported clock modes

0f611a8

Bring FPGA SPI tests into SPI feature branch

3ac2593

Add documentation for FPGA-Test-Shield SPI tests (new HAL API)

7333acf

Add header files for fpga spi tests and map test cases to defined beh…

b92b497

…avior. Also, update names of the test functions (basic test and fpga tests) so they are more consistent and unique.

mprse force-pushed the bring_fpga_spi_tests branch from 844cc62 to b92b497 Compare July 5, 2019 09:56

Disable nanostack-border-router example for NUCLEO_F429ZI

372d848

0xc0170 added needs: CI and removed needs: work labels Jul 5, 2019

0xc0170 added the do not merge label Jul 5, 2019

Restrict tests to Arduino FF only and remove unused symbol

bd8142e

mprse force-pushed the bring_fpga_spi_tests branch from 6300dc3 to bd8142e Compare July 8, 2019 06:24

0xc0170 removed the do not merge label Jul 8, 2019

mprse added 3 commits July 8, 2019 13:32

Disable nanostack-border-router example for K66F

13fc600

TARGET_TMPM4G9/spi_api.c: Add missing #endif

b9218c8

EP_AGORA: Remove SPIF component.

b06b57c

SPI is disabled for this target on spi feature branch.

mprse force-pushed the bring_fpga_spi_tests branch from 83c8c11 to b06b57c Compare July 8, 2019 11:38

0xc0170 added ready for merge and removed needs: CI labels Jul 8, 2019

0xc0170 merged commit f88b7cb into ARMmbed:feature-hal-spec-spi Jul 8, 2019

0xc0170 removed the ready for merge label Jul 8, 2019

Bring FPGA SPI tests to feature-hal-spec-spi #10816

Bring FPGA SPI tests to feature-hal-spec-spi #10816

Uh oh!

Conversation

mprse commented Jun 12, 2019

Description

Pull request type

Reviewers

Uh oh!

ciarmcom commented Jun 12, 2019

Uh oh!

adbridge commented Jun 20, 2019

Uh oh!

mprse commented Jun 21, 2019

Uh oh!

jamesbeyond commented Jul 3, 2019

Uh oh!

jamesbeyond left a comment

Choose a reason for hiding this comment

Uh oh!

mprse commented Jul 3, 2019

Uh oh!

jamesbeyond left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jul 5, 2019

Uh oh!

mbed-ci commented Jul 5, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Jul 5, 2019

Uh oh!

mprse commented Jul 5, 2019

Uh oh!

0xc0170 commented Jul 5, 2019

Uh oh!

mbed-ci commented Jul 5, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Jul 5, 2019

Uh oh!

mprse commented Jul 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbed-ci commented Jul 5, 2019

Test run: SUCCESS

Uh oh!

mprse commented Jul 5, 2019

Uh oh!

0xc0170 commented Jul 8, 2019

Uh oh!

mbed-ci commented Jul 8, 2019

Test run: FAILED

Uh oh!

mprse commented Jul 8, 2019

Uh oh!

0xc0170 commented Jul 8, 2019

Uh oh!

mbed-ci commented Jul 8, 2019

Test run: SUCCESS

Uh oh!

mprse commented Jul 8, 2019

Uh oh!

Uh oh!

mprse commented Jul 5, 2019 •

edited

Loading