Add adjust-check-config script to mbedtls importer #10894
Conversation
|
@dgreen-arm, thank you for your changes. |
| # | ||
| # This file is part of mbed TLS (https://tls.mbed.org) | ||
| # | ||
| # Copyright (c) 2019, Arm Limited, All Rights Reserved |
There was a problem hiding this comment.
should have at least SPDX identifier
There was a problem hiding this comment.
It's on line 7 I think?
SPDX-License-Identifier: Apache-2.0
| perl -0pi -e "s/$MATCH_PATTERN//g" "$FILE" | ||
| } | ||
|
|
||
| remove_code \ |
There was a problem hiding this comment.
Please add a comment explaining why this is removed. It'd be good for each modification done by this script to have the rationale, so that we can understand and are able to change it in the future.
|
@dgreen-arm, thank you for your changes. |
In Mbed OS, there are configuration options with Mbed TLS that we are more comfortable allowing than we do with Mbed TLS on its own. Add a check-config adjusting script to enable removing or changing options in check_config.h
dgreen-arm
force-pushed
the
update-mbedtls-makefile
branch
from
b1c3cae to
8f6667d
Compare
|
I added the SPDX identifier and a comment explaining why the check can be removed. |
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
In Mbed OS, there are configuration options with Mbed TLS that we are more comfortable allowing than we do with Mbed TLS on its own. Add a check-config adjusting script to enable removing or changing options in check_config.h
Fixes the entropy sources check that was removed in #10802 from being re-added when the importer script is run.
Pull request type
Reviewers
Release Notes