-
Notifications
You must be signed in to change notification settings - Fork 3k
Add adjust-check-config script to mbedtls importer #10894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
#!/bin/sh | ||
# | ||
# This file is part of mbed TLS (https://tls.mbed.org) | ||
# | ||
# Copyright (c) 2019, Arm Limited, All Rights Reserved | ||
# | ||
# SPDX-License-Identifier: Apache-2.0 | ||
# Licensed under the Apache License, Version 2.0 (the License); you may | ||
# not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# * http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an AS IS BASIS, WITHOUT | ||
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
# Purpose | ||
# | ||
# Removes checks from check_config.h that aren't needed for Mbed OS | ||
# | ||
# Usage: adjust-check-config.sh [path to check_config file] | ||
# | ||
set -eu | ||
|
||
if [ $# -ne 1 ]; then | ||
echo "Usage: $0 path/to/check_config.h" >&2 | ||
exit 1 | ||
fi | ||
|
||
FILE=$1 | ||
|
||
conf() { | ||
$SCRIPT -f $FILE --force $@ | ||
} | ||
|
||
remove_code() { | ||
MATCH_PATTERN=$(IFS=""; printf "%s" "$*") | ||
|
||
perl -0pi -e "s/$MATCH_PATTERN//g" "$FILE" | ||
} | ||
|
||
# When using Mbed Crypto's PSA Entropy Injection feature on Mbed OS, it is | ||
# not required to opt out of having entropy sources added to your entropy | ||
# contexts by default (via MBEDTLS_NO_DEFAULT_ENTROPY_SOURCES). | ||
# As integrated in Mbed OS, MBEDTLS_PSA_INJECT_ENTROPY is compatible with | ||
# actual entropy sources. PSA entropy injection is implemented using the | ||
# standard Mbed TLS NV Seed feature, and is as compatible with other | ||
# entropy sources as the standard Mbed TLS NV Seed feature which does | ||
# support entropy mixing. | ||
remove_code \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add a comment explaining why this is removed. It'd be good for each modification done by this script to have the rationale, so that we can understand and are able to change it in the future. |
||
"#if defined\(MBEDTLS_PSA_INJECT_ENTROPY\) && \\\\\n" \ | ||
" !defined\(MBEDTLS_NO_DEFAULT_ENTROPY_SOURCES\)\n" \ | ||
"#error \"MBEDTLS_PSA_INJECT_ENTROPY is not compatible with actual entropy sources\"\n" \ | ||
"#endif\n" \ | ||
"\n" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should have at least SPDX identifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's on line 7 I think?
SPDX-License-Identifier: Apache-2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, now it is !