Test the FPGA CI Test Shield on all targets - DO NOT MERGE #10965

c1728p9 · 2019-07-04T22:08:01Z

Description

Build in the FPGA CI Test Shield files to all targets so CI can ensure there are no compatibility issues.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

Build in the FPGA CI Test Shield files to all targets so CI can ensure there are no compatibility issues.

ciarmcom · 2019-07-04T23:00:25Z

@c1728p9, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

mprse · 2019-07-05T06:09:54Z

Can we start CI here ASAP, so we have time today to fix build failures?

mbed-ci · 2019-07-05T07:26:25Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_cloud-client-test

0xc0170 · 2019-07-05T07:48:12Z

Restarted client test

0xc0170 · 2019-07-05T07:56:13Z

@mprse all should be good, close this one?

0xc0170 · 2019-07-05T07:56:44Z

@c1728p9 @mprse if we need better test coverage, we should talk to the test team (PR test might not be sufficient but nightly might do).

mprse · 2019-07-05T08:18:26Z

I checked the results for K64F/GCC_ARM:

Build skips:
 * K64F::GCC_ARM::COMPONENTS-TARGET_PSA-TESTS-COMPLIANCE_ITS-TEST_S003
 * K64F::GCC_ARM::FEATURES-CELLULAR-TESTS-API-CELLULAR_DEVICE
 * K64F::GCC_ARM::FEATURES-CELLULAR-TESTS-API-CELLULAR_INFORMATION
 * K64F::GCC_ARM::FEATURES-CELLULAR-TESTS-API-CELLULAR_NETWORK
 * K64F::GCC_ARM::FEATURES-CELLULAR-TESTS-API-CELLULAR_SMS
 * K64F::GCC_ARM::FEATURES-CELLULAR-TESTS-SOCKET-UDP
 * K64F::GCC_ARM::FEATURES-STORAGE-FILESYSTEM-LITTLEFS-TESTS-FILESYSTEM-DIRS
 * K64F::GCC_ARM::FEATURES-STORAGE-FILESYSTEM-LITTLEFS-TESTS-FILESYSTEM-FILES
 * K64F::GCC_ARM::FEATURES-STORAGE-FILESYSTEM-LITTLEFS-TESTS-FILESYSTEM-INTERSPERSED
 * K64F::GCC_ARM::FEATURES-STORAGE-FILESYSTEM-LITTLEFS-TESTS-FILESYSTEM-SEEK
 * K64F::GCC_ARM::FEATURES-STORAGE-FILESYSTEM-LITTLEFS-TESTS-FILESYSTEM_INTEGRATION-FORMAT
 * K64F::GCC_ARM::FEATURES-STORAGE-FILESYSTEM-LITTLEFS-TESTS-FILESYSTEM_RECOVERY-RESILIENCE_FUNCTIONAL
 * K64F::GCC_ARM::FEATURES-STORAGE-FILESYSTEM-LITTLEFS-TESTS-FILESYSTEM_RETARGET-DIRS
 * K64F::GCC_ARM::FEATURES-STORAGE-FILESYSTEM-LITTLEFS-TESTS-FILESYSTEM_RETARGET-FILES
 * K64F::GCC_ARM::FEATURES-STORAGE-FILESYSTEM-LITTLEFS-TESTS-FILESYSTEM_RETARGET-INTERSPERSED
 * K64F::GCC_ARM::FEATURES-STORAGE-FILESYSTEM-LITTLEFS-TESTS-FILESYSTEM_RETARGET-SEEK
 * K64F::GCC_ARM::FEATURES-STORAGE-TESTS-FILESYSTEM-FAT_FILESYSTEM
 * K64F::GCC_ARM::FEATURES-STORAGE-TESTS-FILESYSTEM-MULTIPART_FAT_FILESYSTEM
 * K64F::GCC_ARM::TESTS-LORAWAN-LORARADIO
 * K64F::GCC_ARM::TESTS-MBED-CRYPTO-SANITY
 * K64F::GCC_ARM::TESTS-MBEDMICRO-RTOS-MBED-BASIC
 * K64F::GCC_ARM::TESTS-MBEDMICRO-RTOS-MBED-SYSTIMER
 * K64F::GCC_ARM::TESTS-MBED_DRIVERS-MEM_TRACE
 * K64F::GCC_ARM::TESTS-MBED_HAL-COMMON_TICKERS_FREQ
 * K64F::GCC_ARM::TESTS-MBED_HAL-MPU
 * K64F::GCC_ARM::TESTS-MBED_HAL-QSPI
 * K64F::GCC_ARM::TESTS-MBED_HAL-SPM
 * K64F::GCC_ARM::TESTS-MBED_HAL_FPGA_CI_TEST_SHIELD-ANALOGIN
 * K64F::GCC_ARM::TESTS-MBED_HAL_FPGA_CI_TEST_SHIELD-ANALOGOUT
 * K64F::GCC_ARM::TESTS-MBED_HAL_FPGA_CI_TEST_SHIELD-GPIO
 * K64F::GCC_ARM::TESTS-MBED_HAL_FPGA_CI_TEST_SHIELD-GPIO_IRQ
 * K64F::GCC_ARM::TESTS-MBED_HAL_FPGA_CI_TEST_SHIELD-I2C
 * K64F::GCC_ARM::TESTS-MBED_HAL_FPGA_CI_TEST_SHIELD-PWM
 * K64F::GCC_ARM::TESTS-MBED_HAL_FPGA_CI_TEST_SHIELD-SPI
 * K64F::GCC_ARM::TESTS-MBED_HAL_FPGA_CI_TEST_SHIELD-UART
 * K64F::GCC_ARM::TESTS-NETWORK-EMAC
 * K64F::GCC_ARM::TESTS-NETWORK-MULTIHOMING
 * K64F::GCC_ARM::TESTS-NETWORK-WIFI
 * K64F::GCC_ARM::TESTS-NFC-EEPROM
 * K64F::GCC_ARM::TESTS-PSA-ATTESTATION
 * K64F::GCC_ARM::TESTS-PSA-CRYPTO_ACCESS_CONTROL
 * K64F::GCC_ARM::TESTS-PSA-CRYPTO_INIT
 * K64F::GCC_ARM::TESTS-PSA-ENTROPY_INJECT
 * K64F::GCC_ARM::TESTS-PSA-SPM_CLIENT
 * K64F::GCC_ARM::TESTS-PSA-SPM_SERVER
 * K64F::GCC_ARM::TESTS-PSA-SPM_SMOKE
[mbed] Working path "/builds/ws/mbed-os-ci_build-GCC_ARM@2/mbed-os" (program)

Looks like FPGA CI Test Shield component is disabled 😞 . Maybe it is blocked somewhere in CI?

0xc0170 · 2019-07-05T08:23:41Z

I asked @OPpuolitaival for help, or rather now test team :)

OPpuolitaival · 2019-07-05T09:05:43Z

Manually triggered builds with all targets

mprse · 2019-07-05T09:27:23Z

@OPpuolitaival does the full build will include FPGA test shield component?

This PR adds this component to all targets, but in the first CI results (#10965 (comment)) FPGA test shield component was skipped and we don't know why?

targets/targets.json

Co-Authored-By: Filip Jagodziński <[email protected]>

fkjagodzinski · 2019-07-05T09:45:04Z

@0xc0170, you can cherry-pick this one: fkjagodzinski@f8b5575

Or I can create a new PR if you prefer.

Build in the FPGA CI Test Shield files to all targets so CI can ensure there are no compatibility issues. Based on: 950e140

0xc0170 · 2019-07-05T09:51:40Z

cherry picked here

mprse · 2019-07-05T09:54:41Z

@OPpuolitaival can you please re-trigger builds with all targets?

mbed-ci · 2019-07-05T10:37:47Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR

OPpuolitaival · 2019-07-05T10:49:23Z

Retriggered build with latest changes and all targets

fkjagodzinski · 2019-07-05T11:53:33Z

Regarding latest build failures on EFM32GG11_STK3701 and TB_SENSE_12 -- these targets do not support the arduino form factor for sure. As @maciejbocianski suggested, we should add additional guards to tests.

fkjagodzinski · 2019-07-05T14:17:55Z

I think we could trigger CI build jobs one more time after #10975 is merged.

OPpuolitaival · 2019-07-08T09:05:55Z

PR checks has changed to run all builds. Normal triggering will be fine in next time.

0xc0170 · 2019-07-08T12:49:02Z

CI started

mbed-ci · 2019-07-08T15:38:23Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM

fkjagodzinski · 2019-07-08T19:58:54Z

I can see two errors exposed by mbed_hal_fpga_ci_test_shield/uart (looking at ARM toolchain now):

Undefined symbol serial_set_flow_control:
- ARCH_MAX
- K22F
- K82F
- KL25Z
- KL43Z
- KL46Z
- KL82Z
- KW41Z
- LPC54114
- LPC546XX
- MIMXRT1050_EVK
- MOTE_L152RC
- WIZWIKI_W7500
- WIZWIKI_W7500P
Undefined symbol serial_free:
- FUTURE_SEQUANA
- FUTURE_SEQUANA_M0

Regarding the serial_set_flow_control -- currently, this function should be always implemented if the target has DEVICE_SERIAL defined. There are no additional guards there.

mbed-os/hal/serial_api.h

Line 222 in 358046e

    
           void serial_set_flow_control(serial_t *obj, FlowControl type, PinName rxflow, PinName txflow);

How do we proceed now? Shall I open an issue to track this?

mprse · 2019-07-08T20:28:13Z

Undefined symbol serial_set_flow_control

Looks like boards from the list does not have SERIAL_FC feature enabled and probably that is why this function is not implemented. I didn't check logs but, probably the test build fails because mentioned symbol is not found. I think that the flow control part of the test should be compiled only for targets with SERIAL_FC enabled?

Undefined symbol serial_free.

I think we should add at least empty serial_free function for these 2 targets.

0xc0170 · 2019-07-09T08:26:23Z

I think that the flow control part of the test should be compiled only for targets with SERIAL_FC enabled?

That should fix it.

fkjagodzinski · 2019-08-12T12:17:43Z

I can see that all issues found with this PR are resolved now.

@OPpuolitaival, @0xc0170, could you trigger build jobs on all targets one last time, please?

I think this PR has served its purpose, and can be closed as soon as we make sure the FPGA component builds OK now.

0xc0170 · 2019-09-19T11:38:17Z

I think this PR has served its purpose, and can be closed as soon as we make sure the FPGA component builds OK now.

👍 closing

Test the FPGA CI Test Shield on all targets

950e140

Build in the FPGA CI Test Shield files to all targets so CI can ensure there are no compatibility issues.

ciarmcom requested a review from a team July 4, 2019 23:00

ciarmcom added the needs: review label Jul 4, 2019

0xc0170 added do not merge and removed needs: review labels Jul 5, 2019

0xc0170 added needs: review release-version: 5.13.2 and removed do not merge labels Jul 5, 2019

fkjagodzinski reviewed Jul 5, 2019

View reviewed changes

targets/targets.json Outdated Show resolved Hide resolved

targets: fix components addition

70d0aae

Co-Authored-By: Filip Jagodziński <[email protected]>

Test the FPGA CI Test Shield on all targets

3276030

Build in the FPGA CI Test Shield files to all targets so CI can ensure there are no compatibility issues. Based on: 950e140

fkjagodzinski mentioned this pull request Jul 5, 2019

Restrict FPGA tests to Arduino form factor #10975

Merged

artokin added the do not merge label Jul 8, 2019

fkjagodzinski mentioned this pull request Jul 9, 2019

Add DEVICE_SERIAL_FC guards to serial HAL API #10994

Merged

fkjagodzinski mentioned this pull request Jul 16, 2019

FUTURE_SEQUANA: missing serial_free #11057

Closed

adbridge removed the release-version: 5.13.2 label Sep 6, 2019

0xc0170 closed this Sep 19, 2019

Test the FPGA CI Test Shield on all targets - DO NOT MERGE #10965

Test the FPGA CI Test Shield on all targets - DO NOT MERGE #10965

Uh oh!

Conversation

c1728p9 commented Jul 4, 2019

Description

Pull request type

Reviewers

Uh oh!

ciarmcom commented Jul 4, 2019

Uh oh!

mprse commented Jul 5, 2019

Uh oh!

mbed-ci commented Jul 5, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Jul 5, 2019

Uh oh!

0xc0170 commented Jul 5, 2019

Uh oh!

0xc0170 commented Jul 5, 2019

Uh oh!

mprse commented Jul 5, 2019

Uh oh!

0xc0170 commented Jul 5, 2019

Uh oh!

OPpuolitaival commented Jul 5, 2019

Uh oh!

mprse commented Jul 5, 2019

Uh oh!

Uh oh!

fkjagodzinski commented Jul 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Jul 5, 2019

Uh oh!

mprse commented Jul 5, 2019

Uh oh!

mbed-ci commented Jul 5, 2019

Test run: FAILED

Uh oh!

OPpuolitaival commented Jul 5, 2019

Uh oh!

fkjagodzinski commented Jul 5, 2019

Uh oh!

fkjagodzinski commented Jul 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OPpuolitaival commented Jul 8, 2019

Uh oh!

0xc0170 commented Jul 8, 2019

Uh oh!

mbed-ci commented Jul 8, 2019

Test run: FAILED

Uh oh!

fkjagodzinski commented Jul 8, 2019

Uh oh!

mprse commented Jul 8, 2019

Uh oh!

0xc0170 commented Jul 9, 2019

Uh oh!

fkjagodzinski commented Aug 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Sep 19, 2019

Uh oh!

Uh oh!

fkjagodzinski commented Jul 5, 2019 •

edited

Loading

fkjagodzinski commented Jul 5, 2019 •

edited

Loading

fkjagodzinski commented Aug 12, 2019 •

edited

Loading