Add DEVICE_SERIAL_FC guards to serial HAL API #10994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions related to serial flow control should not be exposed if DEVICE_SERIAL_FC is not defined * serial_set_flow_control, * serial_cts_pinmap, * serial_rts_pinmap.
|
@fkjagodzinski, thank you for your changes. |
Fix undefined references to serial_set_flow_control.
0xc0170
approved these changes
Jul 9, 2019
|
CI started |
mprse
reviewed
Jul 9, 2019
Test run: FAILEDSummary: 2 of 4 test jobs failed Failed test jobs:
|
added 2 commits
July 9, 2019 16:05
After adding DEVICE_SERIAL_FC guards to serial_api.h serial_set_flow_control is not available. In case of this implementation, this function is a no-op and may be safely removed.
After adding DEVICE_SERIAL_FC guards to serial_api.h serial_set_flow_control is not available. In case of this implementation, this function is a no-op and may be safely removed.
According to comment in the implementation this target supports the hardware flow control on UART1 peripheral. This patch fixes build errors after adding DEVICE_SERIAL_FC guards to hal/serial_api.h.
|
@0xc0170 @jamesbeyond @mprse I pushed some fixes -- build failures should be resolved now. Could you take another look and re-review? I'm not sure about the fix for mbed-os/targets/TARGET_RDA/TARGET_UNO_91H/serial_api.c Lines 371 to 372 in 28eb39c |
mprse
approved these changes
Jul 10, 2019
0xc0170
approved these changes
Jul 10, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Functions related to serial flow control should not be exposed if
DEVICE_SERIAL_FCis not definedserial_set_flow_control,serial_cts_pinmap,serial_rts_pinmap.The
tests-mbed_hal_fpga_ci_test_shield-uartis also updated here.This patch should fix build errors found here: #10965 (comment).
Pull request type
Reviewers
@0xc0170 @mprse
Release Notes