PSOC6_SB: initial integration of Cypress Secure Boot target CY8CPROTO_064_SB #11018

romanjoe · 2019-07-10T19:11:30Z

Kind request for ARM team!!!

Could you please make a review as soon as possible - we need this for our customer. Ideally at start on the next week.

Description

This PR brings the following major updates to the Cypress PSoC 6 targets for Mbed OS 5.13:

Initial implementation of the Cypress Secure Boot enabled target CY8CPROTO_064_SB (targets/TARGET_Cypress/TARGET_PSOC6/TARGET_CY8CPROTO_064_SB)
Initial implementation of the Cypress Secure Boot tools to support CY8CPROTO_064_SB development (targets/TARGET_Cypress/TARGET_PSOC6/sb-tools)
Added post build functions to integrate Secure Image creation in standard mbed-os build flow.
(tools/targets/PSOC6.py)

Dependencies;

This PR is based on changes introduced in PSOC6: initial integration of Cypress HAL #10692 and is relying on them

Testing results*:
LIN_064_ARMC6_bg.txt
LIN_064_ARMC6_bg_b.txt
LIN_064_GCC_ARM_bg.txt
LIN_064_GCC_ARM_bg_b.txt
MAC_064_GCC_ARM_bg.txt
MAC_064_GCC_ARM_bg_b.txt
WIN_064_ARMC6_bg.txt
WIN_064_ARMC6_bg_b.txt
WIN_064_GCC_ARM_bg.txt
WIN_064_GCC_ARM_bg_b.txt
WIN_064_IAR_bg.txt
WIN_064_IAR_bg_b.txt

(_bg.txt - basic greentea run
(_bg_b.txt - basic greentea buildlog)

there are 2 tests which fail right now. Their root cause is specific implementation of HAL. Our team address this issue right now. And fix will be uploaded.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Please suggest

Release Notes

ciarmcom · 2019-07-10T21:00:32Z

@romanjoe, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-ipcore please review.

artokin · 2019-07-15T13:13:32Z

@romanjoe , #10692 is now merged to master. Would you rebase?

romanjoe · 2019-07-15T13:28:08Z

@romanjoe , #10692 is now merged to master. Would you rebase.

Hi, thank you for response.

I have made a fork from official master right after #10692 was merged to master. So my PR branch has that changes.

mbed-ci · 2019-07-17T13:31:26Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR

romanjoe · 2019-07-17T13:43:44Z

I found an error message from CI log

ImportError: No module named pathlib

this module is required by post build script of Secure Boot tools and is present in requirements.txt targets/TARGET_Cypress/TARGET-PSOC6/sb-tools.

What should i do in this case?

ifyall · 2019-07-19T00:02:40Z

@maclobdell Can you ping someone to assist @romanjoe with the question regarding the post-build script?

SeppoTakalo · 2019-07-22T08:42:15Z

@ARMmbed/mbed-os-tools Can you tel us how those dependencies are handled from platform specific build scripts? Are there any limitations, or should we just accept all dependencies?

mark-edgeworth · 2019-07-22T14:30:04Z

I'm sorry, we do not have enough experience yet with this build system to answer this.

SeppoTakalo · 2019-07-23T09:04:37Z

@ARMmbed/mbed-os-test Are we OK on adding dependencies on per-platform build scripts? Should those be added into main requirements.txt?

SeppoTakalo · 2019-07-25T09:29:23Z

@romanjoe Due the summer holiday period, we have very delayed responses from developer teams. Therefore I have no clear answer how to handle those Python requirements.

In the mean time, I would like to suggest that you add your requirements into the root requirements.txt or find another way around it. That would allow us the test this change, as the CI will dynamically install dependencies.

romanjoe · 2019-07-25T21:30:13Z

Hi @SeppoTakalo, thank you for response. I added platform specific requirements to main requirements.txt of mbed-os.

But i see another problem with CI. Our target uses a specific set of post build tools. To use these tools set of cryptography keys must be generated. These keys are then used for signing hex files, generated by mbed-os.

Problem is, that these keys should be generated by user before starting work with our target. Keys should be unique every time for each user from security perspective reasons. Without keys in targets/TARGET_Cypress/TARGET_PSOC6/sb-tools/keys, mbed-os hexes will be built successfully, but not signed in post build hook which will lead to script error and CI failure.

How we can manage this issue?

PS: We use keys generation as one of jobs on our CI now. No default keys can be used in repositories.

cmonr · 2019-07-25T21:48:26Z

@romanjoe Please review the python failures in Travis CI:

https://travis-ci.org/ARMmbed/mbed-os/jobs/563750975#L247

romanjoe · 2019-07-30T12:48:24Z

Hi, I got this message from travis-ci/tools-py2.7 runner.

Could not find a version that satisfies the requirement trollius==1.0.4 (from pyshark-legacy->icetea<1.3,>=1.2.1->-r requirements.txt (line 21)) (from versions: 2.1, 2.1.post2, 2.2, 2.2.post1)
No matching distribution found for trollius==1.0.4 (from pyshark-legacy->icetea<1.3,>=1.2.1->-r requirements.txt (line 21))
The command "pip install -r requirements.txt" failed and exited with 1 during .

This issue is already tracked in #11124 and is reproducible on all mbed-os versions due to external dependencies.

romanjoe · 2019-07-31T12:48:29Z

Hi, as issue #11124 is resolved and closed now, all automatic CIs are completed.

Only CI needed to be ran is

continuous-integration/jenkins/pr-head

romanjoe · 2019-08-01T09:02:24Z

Hi, again.

Before running last CI stage, which is continuous-integration/jenkins/pr-head please review my comment above #11018 (comment).

Also please consider to review attached GreenTea test reports, generated by our CI system.

romanjoe · 2019-08-30T11:15:12Z

New Ci started

Ni @0xc0170, you have just merger PR11353 from Cypress - changes introduced there can potentially introduce merge conflicts for this PR - should I rebase against master now?

mbed-ci · 2019-08-30T11:23:52Z

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 7
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR

0xc0170 · 2019-08-30T12:02:22Z

I dont see any merge conflicts, but rebase won't hurt. @romanjoe if you can do it now before I restart CI

0xc0170 · 2019-08-30T12:03:57Z

Let me know asap

…ro-rtos-mbed-heap_and_stack failure on ARM compiler.

…ns definition in requirements.txt

…mments, adjusted Readme.md

…d compilation for Python 2.7.

…rganization in PSOC6.py, fixed per PR comments

romanjoe · 2019-08-30T13:06:44Z

@0xc0170 PR rebased - sorry it took more time, because there was a fix needed considering changes is that PR i mentioned

0xc0170 · 2019-08-30T13:13:19Z

CI started

mbed-ci · 2019-08-30T14:58:49Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 8
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-ARM

0xc0170 · 2019-08-30T15:09:32Z

The error above fixed, restarting CI

mbed-ci · 2019-08-30T17:11:42Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 9
Build artifacts

ciarmcom requested review from a team July 10, 2019 21:00

ciarmcom requested a review from a team July 10, 2019 21:00

ciarmcom added the needs: review label Jul 10, 2019

romanjoe force-pushed the cy8c064-sb branch from ffa493c to 7d289d4 Compare July 11, 2019 17:27

vmedcy mentioned this pull request Jul 12, 2019

New Mbed Exporters for Eclipse and VSCode: design proposal #11040

Closed

kotkcy mentioned this pull request Jul 16, 2019

Initial implementation of Cypress Crypto hardware acceleration for mbedTLS #11046

Merged

SeppoTakalo added the needs: CI label Jul 17, 2019

SeppoTakalo removed the needs: CI label Jul 24, 2019

SeppoTakalo added needs: work and removed needs: review labels Jul 25, 2019

SeppoTakalo added needs: CI and removed needs: work labels Aug 1, 2019

romanjoe added 16 commits August 30, 2019 15:10

PSOC6_SB: Initial commit to add CY8CPROTO_064_SB to mbed-os sources.

ed9995e

Fixed IAR linker script.

b15d54f

Updated licenses in files, mentioned in commnets to ARMmbed#11046

4db392c

Updated linker scripts and startup file for ARM - fixes tests-mbedmic…

9d4a697

…ro-rtos-mbed-heap_and_stack failure on ARM compiler.

Updated CyBootloader hexes.

b8639a0

Added example x.509 certificate for provisioning.

7e8d569

Updated BSD license file content.

74c5ea6

Added sb-tools requirements to main mbed-os requirements file.

f22e488

Updated python module requirements.txt

5262cf1

Updated README.md

74e873a

Added licenses types for python packets to LICENSE.md, updated versio…

44401b5

…ns definition in requirements.txt

Removed scripts for provisiongs from repository, made fixes per PR co…

515555e

…mments, adjusted Readme.md

Added check for python version before calling post build action. Fixe…

d289b96

…d compilation for Python 2.7.

Removed import of version specific python modules, improved imports o…

bfe1d04

…rganization in PSOC6.py, fixed per PR comments

Updated target files structure to align with the following BSP PR.

c249bf9

Disabled QSPI for now

9780c90

romanjoe force-pushed the cy8c064-sb branch from 0efa63a to 9780c90 Compare August 30, 2019 13:05

0xc0170 added ready for merge and removed needs: CI labels Aug 30, 2019

0xc0170 merged commit 979e1f0 into ARMmbed:master Aug 30, 2019

adbridge removed the ready for merge label Sep 5, 2019

PSOC6_SB: initial integration of Cypress Secure Boot target CY8CPROTO_064_SB #11018

PSOC6_SB: initial integration of Cypress Secure Boot target CY8CPROTO_064_SB #11018

Uh oh!

Conversation

romanjoe commented Jul 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kind request for ARM team!!!

Description

Pull request type

Reviewers

Release Notes

Uh oh!

ciarmcom commented Jul 10, 2019

Uh oh!

artokin commented Jul 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romanjoe commented Jul 15, 2019

Uh oh!

mbed-ci commented Jul 17, 2019

Test run: FAILED

Uh oh!

romanjoe commented Jul 17, 2019

Uh oh!

ifyall commented Jul 19, 2019

Uh oh!

SeppoTakalo commented Jul 22, 2019

Uh oh!

mark-edgeworth commented Jul 22, 2019

Uh oh!

SeppoTakalo commented Jul 23, 2019

Uh oh!

SeppoTakalo commented Jul 25, 2019

Uh oh!

romanjoe commented Jul 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Jul 25, 2019

Uh oh!

romanjoe commented Jul 30, 2019

Uh oh!

romanjoe commented Jul 31, 2019

Uh oh!

romanjoe commented Aug 1, 2019

Uh oh!

romanjoe commented Aug 30, 2019

Uh oh!

mbed-ci commented Aug 30, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Aug 30, 2019

Uh oh!

0xc0170 commented Aug 30, 2019

Uh oh!

romanjoe commented Aug 30, 2019

Uh oh!

0xc0170 commented Aug 30, 2019

Uh oh!

mbed-ci commented Aug 30, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Aug 30, 2019

Uh oh!

mbed-ci commented Aug 30, 2019

Test run: SUCCESS

Uh oh!

Uh oh!

romanjoe commented Jul 10, 2019 •

edited

Loading

artokin commented Jul 15, 2019 •

edited

Loading

romanjoe commented Jul 25, 2019 •

edited

Loading