Add support for DHCP server with WHD #11320
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kyle-cypress, thank you for your changes. |
0xc0170
requested changes
Aug 26, 2019
|
|
||
| #include "cy_result.h" | ||
| #include "cynetwork_utils.h" | ||
| #include "mbed.h" |
There was a problem hiding this comment.
please include the required headers instead
There was a problem hiding this comment.
Agreed. Will remove "mbed.h" and use only necessary dependency.
@adbridge Please check why this team was not added to reviewers (I manually added it). |
0xc0170
requested changes
Aug 27, 2019
| } | ||
| } | ||
| return temp; | ||
| } |
There was a problem hiding this comment.
Please add new lines at the end of files
The source changes are not tagged as Cypress specific in the reviewers config file. |
Merged
|
Integrated via #11367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable DHCP server for Cypress targets with WHD.
Pull request type
Reviewers
@ARMmbed/team-cypress
Release Notes