Skip to content

Bring down interface when stopping softap #11338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

cydriftcloud
Copy link
Contributor

@cydriftcloud cydriftcloud commented Aug 27, 2019

Description

Brought down the network interface when stopping SoftAP. This is to ensure that the network interface is in correct mode before next starting.

Note this PR depends on PR #11320

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-cypress

Release Notes

@ciarmcom ciarmcom requested review from a team August 27, 2019 01:00
@ciarmcom
Copy link
Member

@cydriftcloud, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

The interface should be brought down when stopping softap.
@cydriftcloud cydriftcloud force-pushed the pr/psoc6-softap-bringdown branch from c89f98b to 5a3562a Compare August 30, 2019 16:00
@cydriftcloud
Copy link
Contributor Author

The preceding PR has been merged and the conflict has been resolved. This PR is targeted for 5.14 release.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2019

@ARMmbed/mbed-os-ipcore Anyone to review?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2019

@cydriftcloud as we are close to 5.14, we might take this for 5.14.1 (needs ipcore review still)

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2019

cc @AnttiKauppila

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 3, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 3, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 208d703 into ARMmbed:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants