-
Notifications
You must be signed in to change notification settings - Fork 3k
Update linker scripts based on latest PDL 1.3 #11354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kyle-cypress, thank you for your changes. |
Needs rebase now |
I'm testing out the linker changes. Specifically testing a pre-built bootloader and pelion client example application for CY8CPROTO_062_4343W with GCC_ARM compiler. I'm testing off of 5.13.x with just this linker update made. (My mbed_app.json sets mbed_rom_start to 0x10000000. This would be better to be located in targets.json.) With the linker changes applied, I get the following error.
This is because the pre-built bootloader file fills the area 0x10000000 - 0x1000C000. It already has the CM0+ area in it. But now the application is being built with the CM0+ in it. So, are you proposing that when building the bootloader project, it does not include the CM0+ area? This is very possible, but I'm not sure your proposed changes provide a clear method for handling this situation. |
After additional testing, I think the linker changes are okay. After adding this to mbed_app.json for an application project, it successfully combines with a pre-built bootloader (which already has the CM0+ area added).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More additional settings might be required to enable bootloader support, but for now the linker changes look good.
Please document this on the board platform page.
"target.extra_labels_remove" : ["CM0P_SLEEP"]
f276f8a
to
3d8653c
Compare
Rebased on the rollup branch from #11367 . Added 3d8653c to address the bootloader issue discussed above by @cy-opm and @maclobdell . |
@kyle-cypress Some PRs were integrated but looks like not properly so Github does not recognize them. Please rebase this one again |
Allow the application to specify this depending on whether/how it is using the bootloader and whether it requires a CM0+ image.
3d8653c
to
bf00ebe
Compare
ci started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
This depends on PDL update (#11326 ) and BSP restructure (#11323 ). The PR branch is based off of the branch for #11323 because the diff does not apply cleanly to master. The unique commit is
f276f8a . It will be rebased once those PRs are merged.
Pull request type
Reviewers
@ARMmbed/team-cypress
Release Notes