-
Notifications
You must be signed in to change notification settings - Fork 3k
[TEST] Add MCU list in RTC automated test #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add "mcu" key with lists of RTC support targets (#define DEVICE_RTC 1 in device.h), now MBED_16 test is not executed by non-RTC targets
This fixes it ,however we should think about something more maintainable. Isn't there a way for singletest to find out if that test is supported or not, besides #error message. I'll speak to @PrzemekWirkus. |
There are few options here:
PS: @toyowata - sorry I can't give you 👍 here, this should be discussed a bit and we should make this a scalable solution. Today RTC, tomorrow other peripheral may be excluded from platform. I do not want to maintain long list of MCUs supporting RTC. It just creates technical debt in |
While I think number 1 would be an easy and adequate solution, other options:
|
More importantly, if a MCU has a separately backed up RTC could we ensure this works and does not get reset on power down or MCU reset. NXP and Freescale targets appear to have this correctly configured, whereas non of the ST targets I have work correctly and SiLabs Gecko's have the same problem at the moment, however I believe this on the to-do list. |
I think adding RTC to the peripherals list is the most scalable option discussed so far. It wouldn't take much time to add the RTC peripheral for each platform (@toyowata has done the hard part already and figured out which platforms support RTC) and whoever adds a new platform will be responsible for adding the peripheral. |
All, All, than you very much for suggestions. I agreed that there should be the peripheral list for RTC targets and automated test MBED_16 should be tested only RTC enabled targets. I will close this PR. |
As a result of discussion here: ARMmbed#1154
commit 5b65ac9848f232b37ccf57b3cea3c8abd8788eb8 Merge: 4778e33 167456e Author: 0xc0170 <[email protected]> Date: Wed Jun 10 13:18:07 2015 +0100 Merge branch 'master' of https://github.com/toyowata/mbed into toyowata-master commit 167456e Author: Toyomasa Watarai <[email protected]> Date: Wed Jun 10 11:22:47 2015 +0900 Change target name not use low cases Rev.101 mbed library support WIZnet platfrom. However, we got build error as below by online compiler: Target “WIZWIKI_W7500” is not recognized This is because target name contained low cases (e.g. WIZwiki_W7500). The target name should be all upper case. commit b988a53 Merge: f74cbe0 a140fc6 Author: Toyomasa Watarai <[email protected]> Date: Wed Jun 10 11:10:37 2015 +0900 Merge remote-tracking branch 'upstream/master' commit f74cbe0 Author: Toyomasa Watarai <[email protected]> Date: Wed Jun 10 11:07:02 2015 +0900 Revert RTC test script change As a result of discussion here: #1154 commit a4923ff Author: Toyomasa Watarai <[email protected]> Date: Thu Jun 4 00:17:06 2015 +0900 [TEST] Add MCU list in RTC automated test * Add "mcu" key with lists of RTC support targets (#define DEVICE_RTC 1 in device.h), now MBED_16 test is not executed by non-RTC targets
in device.h), now MBED_16 test is not executed by non-RTC targets