Change target name not use low cases #1171
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add "mcu" key with lists of RTC support targets (#define DEVICE_RTC 1 in device.h), now MBED_16 test is not executed by non-RTC targets
As a result of discussion here: ARMmbed#1154
Rev.101 mbed library support WIZnet platfrom. However, we got build error as below by online compiler: Target “WIZWIKI_W7500” is not recognized This is because target name contained low cases (e.g. WIZwiki_W7500). The target name should be all upper case.
|
We overlooked this typo 😞 I see you got not relevant git history here, I'll manually squash this into one commit as the last one is the one. Please clean your history before sending PR. Branching is useful! |
0xc0170
added a commit
that referenced
this pull request
Jun 10, 2015
commit 5b65ac9848f232b37ccf57b3cea3c8abd8788eb8 Merge: 4778e33 167456e Author: 0xc0170 <[email protected]> Date: Wed Jun 10 13:18:07 2015 +0100 Merge branch 'master' of https://github.com/toyowata/mbed into toyowata-master commit 167456e Author: Toyomasa Watarai <[email protected]> Date: Wed Jun 10 11:22:47 2015 +0900 Change target name not use low cases Rev.101 mbed library support WIZnet platfrom. However, we got build error as below by online compiler: Target “WIZWIKI_W7500” is not recognized This is because target name contained low cases (e.g. WIZwiki_W7500). The target name should be all upper case. commit b988a53 Merge: f74cbe0 a140fc6 Author: Toyomasa Watarai <[email protected]> Date: Wed Jun 10 11:10:37 2015 +0900 Merge remote-tracking branch 'upstream/master' commit f74cbe0 Author: Toyomasa Watarai <[email protected]> Date: Wed Jun 10 11:07:02 2015 +0900 Revert RTC test script change As a result of discussion here: #1154 commit a4923ff Author: Toyomasa Watarai <[email protected]> Date: Thu Jun 4 00:17:06 2015 +0900 [TEST] Add MCU list in RTC automated test * Add "mcu" key with lists of RTC support targets (#define DEVICE_RTC 1 in device.h), now MBED_16 test is not executed by non-RTC targets
|
Merged squashed manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rev.101 mbed library support WIZnet platfrom. However, we got build error as below by online compiler:
This is because target name contained low cases (e.g. WIZwiki_W7500).
The target name should be all upper case.